Bugzilla – Attachment 24725 Details for
Bug 9579
Facets truncation broken for multi-byte characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9579: Facets truncation broken for multi-byte characters
PASSED-QA-Bug-9579-Facets-truncation-broken-for-mu.patch (text/plain), 2.38 KB, created by
Katrin Fischer
on 2014-01-25 08:38:41 UTC
(
hide
)
Description:
[PASSED QA] Bug 9579: Facets truncation broken for multi-byte characters
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-01-25 08:38:41 UTC
Size:
2.38 KB
patch
obsolete
>From aa50f87e457364622c2921612f0ddb13019dee5c Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 15 Jan 2014 21:06:04 -0300 >Subject: [PATCH] [PASSED QA] Bug 9579: Facets truncation broken for multi-byte > characters >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >We seem to be relying on whatever Zoom::Results->render return, and >Perl doesn't explicitly consider it UNICODE data. That's why CORE::substr >(and probably CORE::length too) cut the bytes wrong. > >This patch just decodes the UTF-8 data that render() returns and then >Perl behaves, heh. > >It uses Encode::decode_utf8 which is already a dependency for the current >stable Koha releases. > >REVISED TEST PLAN >----------------- >1) Import the attached sample records. >2) Rebuild your indexes >3) In OPAC search for ÙÙÙÙÙتبات : ÙØ¨Ø³Ù Ø Ùر٠>-- There will be ugly diamonds with question marks in the facets >4) apply the patch >5) Search again. >-- The names will be properly truncated. >NOTE: This test assumes FacetLabelTruncationLength = 20. > >Regards >To+ > >Sponsored-by: Universidad Nacional de Cordoba > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. >Works as described, tested with several German, English and >the Arabic test record. Arabic strings now display correctly >and no regression was found. >--- > C4/Search.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 18a0f5f..d09fe4c 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -36,6 +36,7 @@ use URI::Escape; > use Business::ISBN; > use MARC::Record; > use MARC::Field; >+use Encode qw/decode_utf8/; > use utf8; > use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG); > >@@ -503,8 +504,8 @@ sub getRecords { > $size > $facets_maxrecs ? $facets_maxrecs : $size; > for my $facet (@$facets) { > for ( my $j = 0 ; $j < $jmax ; $j++ ) { >- my $render_record = >- $results[ $i - 1 ]->record($j)->render(); >+ my $render_record = decode_utf8( >+ $results[ $i - 1 ]->record($j)->render()); > my @used_datas = (); > foreach my $tag ( @{ $facet->{tags} } ) { > >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9579
:
15202
|
15259
|
16942
|
16953
|
24425
|
24426
|
24430
|
24684
|
24725
|
24959