Attachment 24784 Details for Bug 8000 – Bug 8000 - Override emails of every message sent from Koha

[patch] Bug 8000 - Override emails of every message sent from Koha

Bug-8000---Override-emails-of-every-message-sent-f.patch (text/plain), 5.06 KB, created by Blou on 2014-01-27 21:32:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Blou

Created: 2014-01-27 21:32:44 UTC

Size: 5.06 KB

patch

obsolete

>From 9f27900c4313814337aeeec752559f1f7784f736 Mon Sep 17 00:00:00 2001
>From: Blou <philippe.blouin@inlibro.com>
>Date: Mon, 27 Jan 2014 16:31:14 -0500
>Subject: [PATCH] Bug 8000 - Override emails of every message sent from Koha
>
>Note: rebased to 3.15
>
>For testing purposes, we do not want emails sent to (legitimate) users.  And sometime we also like to actually see what would be generated for the users.  This preference will allow to override every message sent by koha with a new (temporary) To address.  Leave it empty for normal usage.
>
>C4/Letters.pm
>installer/data/mysql/sysprefs.sql
>installer/data/mysql/updatedatabase.pl
>koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>
>TESTING:
>0) Run updatedatabase.pl
>1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails.
>2) Have koha generate an email to a user.  Or any other mean prefered that cause Koha to send email.
>3) Validate that the email is NOT sent to the user.
>4) Validate that the email IS sent to the overriding address.
>5) Clean the preference
>6) Redo the test, validate that the email is going to the right address.
>
>PS Not sure if those steps are precise enough.  I'm not comfortable enough to specify the best way to generate emails, I personnally had to hack it in my environment.  Feedbacks welcomed.
>---
> C4/Letters.pm                                                   |    2 ++
> installer/data/mysql/sysprefs.sql                               |    1 +
> installer/data/mysql/updatedatabase.pl                          |    7 +++++++
> .../intranet-tmpl/prog/en/modules/admin/preferences/admin.pref  |    5 +++++
> 4 files changed, 15 insertions(+)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 2595369..d29a368 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -926,6 +926,8 @@ sub _send_message_by_email {
> 
>     my $member = C4::Members::GetMember( 'borrowernumber' => $message->{'borrowernumber'} );
>     my $to_address = $message->{'to_address'};
>+    my $sendAllEmailsTo = C4::Context->preference('SendAllEmailsTo');
>+    $to_address = $sendAllEmailsTo if ($sendAllEmailsTo && $sendAllEmailsTo =~ /@/ ); # some validation.  This could be improved.
>     unless ($to_address) {
>         unless ($member) {
>             warn "FAIL: No 'to_address' and INVALID borrowernumber ($message->{borrowernumber})";
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 1668d37..e330513 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -335,6 +335,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('SelfCheckHelpMessage','','70|10','Enter HTML to include under the basic Web-based Self Checkout instructions on the Help page','Textarea'),
> ('SelfCheckReceiptPrompt','1','NULL','If ON, print receipt dialog pops up when self checkout is finished','YesNo'),
> ('SelfCheckTimeout','120','','Define the number of seconds before the Web-based Self Checkout times out a patron','Integer'),
>+('SendAllEmailsTo','',NULL,'This email will replace the To address in every message sent by the system.  This is meant to help testing only.','Textarea'),
> ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'),
> ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'),
> ('SessionStorage','mysql','mysql|Pg|tmp','Use database or a temporary file for storing session data','Choice'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index f98daa7..a1a5ad7 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -7945,6 +7945,13 @@ if (CheckVersion($DBversion)) {
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.15.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SendAllEmailsTo','',NULL,'This email will replace the To address in every message sent by the system.  This is meant to help testing and validation only.','Textarea')");
>+    print "Upgrade to $DBversion done (Bug 8000 - system preferences to override the destination of every email sent by the system.)\n";
>+    SetVersion ($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index 1215ac1..3f2a7c0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -40,6 +40,11 @@ Administration:
>                   yes: Allow
>                   no: "Don't allow"
>             - staff and patrons to create and view saved lists of books.
>+        -
>+            - Redirect all emails from Koha to 
>+            - pref: SendAllEmailsTo
>+              class: email
>+            - instead of their intended user. 
>     Login options:
>         -
>             - Automatically log out users after
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 8000: 21976 | 22315 | 24784 | 25917 | 25919 | 25920 | 25923 | 25924 | 25925 | 25926 | 25927 | 25928 | 25939 | 25950 | 25951 | 26446 | 37463 | 37464 | 37465 | 37466 | 37467 | 37468 | 37469 | 37472 | 37473 | 37474 | 37475 | 37476 | 37477 | 37478 | 37481 | 37482 | 37483 | 37484 | 37485 | 37486 | 37487 | 39985 | 39986 | 39987 | 39988 | 39989 | 39990 | 39991 | 39992 | 40215 | 40216 | 40217 | 40218 | 40219 | 40220 | 40221 | 40222 | 40223 | 40224 | 40225 | 40226 | 40227 | 40228 | 40229 | 40230 | 46354 | 46355 | 46356 | 46357 | 46358 | 46359 | 46360 | 46361 | 46362 | 49991 | 49992 | 49993 | 49998 | 49999 | 50000 | 55940 | 58434 | 62863 | 67155 | 70086 | 70087 | 70484 | 74110 | 74111 | 74848 | 80370 | 81487 | 81488 | 81589 | 81590 | 81591 | 84801 | 84802 | 84803 | 84804 | 84805 | 86861 | 86862 | 86863 | 86864 | 86865 | 88874 | 88875 | 88876 | 88877 | 88878 | 88879