Bugzilla – Attachment 24902 Details for
Bug 11645
Cannot remove instructors from course whose card number begins with a 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11645 - Cannot remove instructors from course whose card number begins with a 0
Bug-11645---Cannot-remove-instructors-from-course-.patch (text/plain), 1.71 KB, created by
Kyle M Hall (khall)
on 2014-01-30 18:51:33 UTC
(
hide
)
Description:
Bug 11645 - Cannot remove instructors from course whose card number begins with a 0
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-01-30 18:51:33 UTC
Size:
1.71 KB
patch
obsolete
>From 68d9dd994e03234f93a49c042b44e55085317636 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 30 Jan 2014 13:49:39 -0500 >Subject: [PATCH] Bug 11645 - Cannot remove instructors from course whose card number begins with a 0 > >It appears that if an instructor's card number begins with a 0, that >instructor cannot be removed from a course. > >Test Plan: >1) Create a patron with a card number "012345" >2) Add this patron to a course >3) Click the "remove" link for that instructor >4) Note that nothing happens >5) Apply this patch >6) Reload the page >7) Repeat stepts 2-3 >8) Note you can now remove the instructor >--- > .../prog/en/modules/course_reserves/course.tt | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >index 1f5aca8..605f4d3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt >@@ -57,7 +57,8 @@ > }); > > function AddInstructor( name, cardnumber ) { >- div = "<div id='borrower_" + cardnumber + "'>" + name + " ( <a href='#' onclick='RemoveInstructor(" + cardnumber + ");return false;'> Remove </a> ) <input type='hidden' name='instructors' value='" + cardnumber + "' /></div>"; >+ div = "<div id='borrower_" + cardnumber + "'>" + name + " ( <a href='#' onclick='RemoveInstructor(\"" + cardnumber + "\");return false;'> Remove </a> )"; >+ div += "<input type='hidden' name='instructors' value='" + cardnumber + "' /></div>"; > $('#instructors').append( div ); > > $('#find_instructor').val('').focus(); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11645
: 24902