Attachment 24903 Details for Bug 11411 – Bug 11411 - Bootstrap theme (enhancement) for (right to left)

[patch] Bug 11411 - Bootstrap theme (enhancement) for (right to left)

Bug-11411---Bootstrap-theme-enhancement-for-right-.patch (text/plain), 14.05 KB, created by Owen Leonard on 2014-01-30 19:21:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-01-30 19:21:51 UTC

Size: 14.05 KB

patch

obsolete

>From 83baa2a163464d2cf7de8ee2e1215e32241d5215 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 30 Jan 2014 14:17:10 -0500
>Subject: [PATCH] Bug 11411 - Bootstrap theme (enhancement) for (right to
> left)
>Content-Type: text/plain; charset="utf-8"
>
>This patch improves Koha's layout when a right-to-left language is being
>displayed by correcting a float set by the right-to-left version of
>Bootstrap CSS.
>
>The patch modifies the right-to-left Less file and includes a
>now-minified version of the compiled CSS.
>
>To test, install a right-to-left language like ar-Arab. Apply the patch
>and view the OPAC under the Bootstrap theme. When logged in, the
>aligned to the left.
>---
> .../opac-tmpl/bootstrap/css/right-to-left.css      |  421 +-------------------
> .../opac-tmpl/bootstrap/less/right-to-left.less    |    6 +
> 2 files changed, 7 insertions(+), 420 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css b/koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css
>index c734b13..eab21e9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css
>@@ -1,420 +1 @@
>-.popup {
>-  padding-right: 0;
>-  padding-left: 0;
>-}
>-a.cancel {
>-  padding-right: 1em;
>-}
>-h1#libraryname {
>-  float: right !important;
>-}
>-caption {
>-  text-align: right;
>-}
>-#basketcount span {
>-  margin: 0 .9em 0 0;
>-}
>-#koha_url p {
>-  float: left;
>-}
>-.actions a {
>-  /* List contents remove from list link */
>-
>-}
>-.actions a.hold {
>-  margin-left: 1em;
>-  padding-right: 21px;
>-}
>-.actions a.addtocart {
>-  margin-left: 1em;
>-  padding-right: 20px;
>-}
>-.actions a.addtoshelf {
>-  margin-left: 1em;
>-  padding-right: 20px;
>-}
>-.actions a.addtolist {
>-  margin-left: 1em;
>-  padding-right: 20px;
>-}
>-.actions a.tag_add {
>-  margin-left: 1em;
>-  padding-right: 20px;
>-}
>-.actions a.removefromlist {
>-  margin-left: 1em;
>-  padding-right: 15px;
>-}
>-.ui-tabs .ui-tabs-nav li {
>-  margin-left: .4em;
>-}
>-.statictabs li {
>-  float: right;
>-  margin-left: 0.4em;
>-}
>-.statictabs li a {
>-  float: right;
>-}
>-#bookcover .no-image {
>-  margin-left: 10px;
>-}
>-th.sum {
>-  text-align: left;
>-}
>-th[scope=row] {
>-  text-align: left;
>-}
>-fieldset.rows {
>-  float: right;
>-  clear: right;
>-}
>-fieldset.rows label,
>-fieldset.rows .label {
>-  float: right;
>-  margin-left: 1em;
>-  text-align: left;
>-}
>-fieldset.rows ol.lradio label {
>-  margin-left: 0;
>-}
>-fieldset.rows ol.lradio label.lradio {
>-  float: right;
>-  margin-left: 1em;
>-}
>-fieldset.rows li {
>-  float: right;
>-  clear: right;
>-}
>-fieldset.rows li.lradio {
>-  padding-right: 8.5em;
>-}
>-fieldset.rows li.lradio label {
>-  margin: 0 1em 0 0;
>-}
>-div.rows {
>-  float: right;
>-  clear: right;
>-}
>-div.rows span.label {
>-  float: right;
>-  margin-left: 1em;
>-  text-align: right;
>-}
>-div.rows ol {
>-  margin-right: 0;
>-  padding: .5em 0 0 1em;
>-}
>-div.rows li {
>-  float: right;
>-  clear: right;
>-}
>-div.rows ul li {
>-  margin-right: 7.3em;
>-}
>-div.rows ul li:first-child {
>-  margin-right: 0;
>-}
>-.toolbar {
>-  padding: 3px 5px 5px 3px;
>-}
>-.toolbar label {
>-  margin-right: .5em;
>-}
>-.toolbar .hold,
>-.toolbar #tagsel_tag {
>-  padding-right: 28px;
>-}
>-.toolbar li a {
>-  border-right: 1px solid #e8e8e8;
>-}
>-.toolbar li:first-child a {
>-  border-right: 0;
>-}
>-.toolbar ul {
>-  padding-right: 0;
>-}
>-#basket .toolbar {
>-  padding: 7px 9px 9px 5px;
>-}
>-#selections-toolbar {
>-  padding-right: 10px;
>-}
>-#tagsel_span input.submit,
>-#tagsel_tag {
>-  padding-right: 25px;
>-}
>-#tagsel_span input.disabled,
>-#tagsel_span input.disabled:hover,
>-#tagsel_span input.hold.disabled,
>-#tagsel_span input.hold.disabled:hover,
>-#selections-toolbar input.hold.disabled,
>-#selections-toolbar input.hold.disabled:hover,
>-#selections-toolbar a.disabled,
>-#selections-toolbar a.disabled:hover {
>-  padding-right: 23px;
>-}
>-#views {
>-  padding: 0 0.2em 0.2em 2em;
>-}
>-#bibliodescriptions,
>-#isbdcontents {
>-  clear: right;
>-}
>-#bookcover {
>-  float: right;
>-}
>-#bookcover .no-image {
>-  margin-left: 10px;
>-}
>-#bookcover img {
>-  margin: 0 0 1em 1em;
>-}
>-/* pagination */
>-.results-pagination {
>-  right: -1px;
>-}
>-.back {
>-  float: left;
>-}
>-.pagination_list ul {
>-  padding-right: 0px;
>-}
>-.pagination_list li a {
>-  padding-right: 0px;
>-}
>-.pagination_list .li_pag_index {
>-  float: right;
>-  padding-left: 10px;
>-  text-align: left;
>-}
>-.pg_menu li.back_results a {
>-  border-right: 1px solid #D0D0D0;
>-  border-left: 1px solid #D0D0D0;
>-}
>-.pg_menu li a,
>-.pg_menu li span {
>-  float: right;
>-}
>-#listResults li {
>-  margin-left: 1px;
>-}
>-/* nav */
>-.nav_pages .close_pagination {
>-  padding-left: 10px;
>-  left: 3px;
>-}
>-.nav_pages li {
>-  float: right;
>-}
>-.nav_pages li ul {
>-  float: right;
>-}
>-#format,
>-#furthersearches {
>-  padding-right: 35px;
>-}
>-.highlight_controls {
>-  float: right;
>-}
>-a.addtocart {
>-  padding-right: 35px;
>-}
>-a.addtoshelf {
>-  padding-right: 35px;
>-}
>-a.brief {
>-  padding-right: 27px;
>-}
>-a.detail {
>-  padding-right: 27px;
>-}
>-a.download {
>-  padding-right: 20px;
>-}
>-a.editshelf {
>-  padding-right: 26px;
>-}
>-a.empty {
>-  padding-right: 30px;
>-}
>-a.hide {
>-  padding-right: 26px;
>-}
>-a.highlight_toggle {
>-  padding-right: 35px;
>-}
>-a.hold,
>-input.hold {
>-  padding-right: 23px;
>-}
>-a.incart {
>-  padding-right: 35px;
>-}
>-a.new {
>-  padding-right: 23px;
>-}
>-a.print-small {
>-  padding-right: 30px;
>-}
>-a.print-large {
>-  padding-right: 35px;
>-}
>-a.removeitems,
>-a.deleteshelf {
>-  padding-right: 25px;
>-}
>-a.reserve {
>-  padding-right: 35px;
>-}
>-a.send {
>-  padding-right: 28px;
>-}
>-a.tag_add {
>-  padding-right: 27px;
>-}
>-input.editshelf {
>-  padding-right: 29px;
>-}
>-.newshelf {
>-  padding-right: 28px;
>-}
>-.deleteshelf {
>-  padding-right: 25px;
>-}
>-#login4tags {
>-  padding-right: 20px;
>-}
>-.tag_results_input {
>-  margin-right: 1em;
>-}
>-#social_networks span {
>-  float: right;
>-  margin: .5em .5em .5em 0 !important;
>-}
>-#social_networks div {
>-  float: right !important;
>-  margin: .5em .2em .5em 0 !important;
>-}
>-#marc td,
>-#marc th {
>-  text-align: right;
>-}
>-#marc .results_summary {
>-  clear: right;
>-}
>-#plainmarc th {
>-  text-align: right;
>-}
>-#renewcontrols {
>-  float: left;
>-}
>-.authstanza li {
>-  margin-right: 0.5em;
>-}
>-#didyoumean {
>-  text-align: right;
>-}
>-.authlink {
>-  padding-right: 0.25em;
>-}
>-#search-facets h4 a,
>-#menu h4 a {
>-  border-radius: 8px 0 0 8px;
>-}
>-#menu {
>-  border: 0 solid #D8D8D8;
>-  border-left-width: 1px;
>-}
>-#menu li a {
>-  border-radius: 0 5px 5px 0;
>-  margin-left: -1px;
>-}
>-#menu li.active a {
>-  border-left-width: 0;
>-  border-right-width: 1px;
>-}
>-/* Search results add to cart (lists disabled) */
>-.addto a.addtocart {
>-  padding-right: 33px;
>-}
>-.searchresults a.highlight_toggle {
>-  padding: 0 21px 0 10px;
>-}
>-.commentline .avatar {
>-  float: left;
>-  padding-right: .5em;
>-}
>-span.sep {
>-  padding: 0 .5em 0 .2em;
>-}
>-/* style for PM-generated pagination bar */
>-.pages span:first-child,
>-.pages a:first-child {
>-  border-bottom-right-radius: 3px;
>-  border-top-right-radius: 3px;
>-}
>-.pages span:last-child,
>-.pages a:last-child {
>-  border-width: 1px 0 1px 1px;
>-  border-bottom-left-radius: 3px;
>-  border-top-left-radius: 3px;
>-}
>-.pages .inactive,
>-.pages .currentPage,
>-.pages a {
>-  border-width: 1px 0 1px 1px;
>-  float: right;
>-}
>-.pages a[rel='last'] {
>-  border-bottom-left-radius: 3px;
>-  border-top-left-radius: 3px;
>-}
>-.close {
>-  left: auto;
>-}
>-/* Redefine a new style for Bootstrap's class "close" since we use that already */
>-/* Use <a class="closebtn" href="#">&times;</a> */
>-.alert .closebtn {
>-  left: -21px;
>-}
>-.closebtn {
>-  float: left;
>-}
>-#logo {
>-  float: right !important;
>-}
>-/* Class to be added to toolbar when it starts being fixed at the top of the screen*/
>-.floating {
>-  -webkit-box-shadow: 0px 0px 2px 3px rgba(0, 0, 0, 0.4);
>-  box-shadow: 0px 0px 2px 3px rgba(0, 0, 0, 0.4);
>-}
>-.table .sorting_asc {
>-  padding-left: 19px;
>-  background: url("../images/asc.gif") no-repeat scroll left center #ecede6;
>-}
>-.table .sorting_desc {
>-  padding-left: 19px;
>-  background: url("../images/desc.gif") no-repeat scroll left center #ecede6;
>-}
>-.table .sorting {
>-  padding-left: 19px;
>-  background: url("../images/ascdesc.gif") no-repeat scroll left center #ecede6;
>-}
>-.table .nosort,
>-.table .nosort.sorting_asc,
>-.table .nosort.sorting_desc,
>-.table .nosort.sorting {
>-  padding-left: 19px;
>-}
>-.tags ul {
>-  margin-right: 0;
>-}
>-.coverimages {
>-  float: left;
>-}
>-#i18nMenu {
>-  margin-right: 1em;
>-}
>-#overdrive-results {
>-  padding-right: 1em;
>-}
>+.popup{padding-right:0;padding-left:0}a.cancel{padding-right:1em}h1#libraryname{float:right!important}caption{text-align:right}#basketcount span{margin:0 .9em 0 0}#koha_url p{float:left}.actions a.hold{margin-left:1em;padding-right:21px}.actions a.addtocart{margin-left:1em;padding-right:20px}.actions a.addtoshelf{margin-left:1em;padding-right:20px}.actions a.addtolist{margin-left:1em;padding-right:20px}.actions a.tag_add{margin-left:1em;padding-right:20px}.actions a.removefromlist{margin-left:1em;padding-right:15px}.ui-tabs .ui-tabs-nav li{margin-left:.4em}.statictabs li{float:right;margin-left:.4em}.statictabs li a{float:right}#bookcover .no-image{margin-left:10px}th.sum{text-align:left}th[scope=row]{text-align:left}fieldset.rows{float:right;clear:right}fieldset.rows label,fieldset.rows .label{float:right;margin-left:1em;text-align:left}fieldset.rows ol.lradio label{margin-left:0}fieldset.rows ol.lradio label.lradio{float:right;margin-left:1em}fieldset.rows li{float:right;clear:right}fieldset.rows li.lradio{padding-right:8.5em}fieldset.rows li.lradio label{margin:0 1em 0 0}div.rows{float:right;clear:right}div.rows span.label{float:right;margin-left:1em;text-align:right}div.rows ol{margin-right:0;padding:.5em 0 0 1em}div.rows li{float:right;clear:right}div.rows ul li{margin-right:7.3em}div.rows ul li:first-child{margin-right:0}.toolbar{padding:3px 5px 5px 3px}.toolbar label{margin-right:.5em}.toolbar .hold,.toolbar #tagsel_tag{padding-right:28px}.toolbar li a{border-right:1px solid #e8e8e8}.toolbar li:first-child a{border-right:0}.toolbar ul{padding-right:0}#basket .toolbar{padding:7px 9px 9px 5px}#selections-toolbar{padding-right:10px}#tagsel_span input.submit,#tagsel_tag{padding-right:25px}#tagsel_span input.disabled,#tagsel_span input.disabled:hover,#tagsel_span input.hold.disabled,#tagsel_span input.hold.disabled:hover,#selections-toolbar input.hold.disabled,#selections-toolbar input.hold.disabled:hover,#selections-toolbar a.disabled,#selections-toolbar a.disabled:hover{padding-right:23px}#views{padding:0 .2em .2em 2em}#bibliodescriptions,#isbdcontents{clear:right}#bookcover{float:right}#bookcover .no-image{margin-left:10px}#bookcover img{margin:0 0 1em 1em}.results-pagination{right:-1px}.back{float:left}.pagination_list ul{padding-right:0}.pagination_list li a{padding-right:0}.pagination_list .li_pag_index{float:right;padding-left:10px;text-align:left}.pg_menu li.back_results a{border-right:1px solid #d0d0d0;border-left:1px solid #d0d0d0}.pg_menu li a,.pg_menu li span{float:right}#listResults li{margin-left:1px}.nav_pages .close_pagination{padding-left:10px;left:3px}.nav_pages li{float:right}.nav_pages li ul{float:right}#format,#furthersearches{padding-right:35px}.highlight_controls{float:right}a.addtocart{padding-right:35px}a.addtoshelf{padding-right:35px}a.brief{padding-right:27px}a.detail{padding-right:27px}a.download{padding-right:20px}a.editshelf{padding-right:26px}a.empty{padding-right:30px}a.hide{padding-right:26px}a.highlight_toggle{padding-right:35px}a.hold,input.hold{padding-right:23px}a.incart{padding-right:35px}a.new{padding-right:23px}a.print-small{padding-right:30px}a.print-large{padding-right:35px}a.removeitems,a.deleteshelf{padding-right:25px}a.reserve{padding-right:35px}a.send{padding-right:28px}a.tag_add{padding-right:27px}input.editshelf{padding-right:29px}.newshelf{padding-right:28px}.deleteshelf{padding-right:25px}#login4tags{padding-right:20px}.tag_results_input{margin-right:1em}#social_networks span{float:right;margin:.5em .5em .5em 0!important}#social_networks div{float:right!important;margin:.5em .2em .5em 0!important}#marc td,#marc th{text-align:right}#marc .results_summary{clear:right}#plainmarc th{text-align:right}#renewcontrols{float:left}.authstanza li{margin-right:.5em}#didyoumean{text-align:right}.authlink{padding-right:.25em}#search-facets h4 a,#menu h4 a{border-radius:8px 0 0 8px}#menu{border:0 solid #d8d8d8;border-left-width:1px}#menu li a{border-radius:0 5px 5px 0;margin-left:-1px}#menu li.active a{border-left-width:0;border-right-width:1px}.addto a.addtocart{padding-right:33px}.searchresults a.highlight_toggle{padding:0 21px 0 10px}.commentline .avatar{float:left;padding-right:.5em}span.sep{padding:0 .5em 0 .2em}.pages span:first-child,.pages a:first-child{border-bottom-right-radius:3px;border-top-right-radius:3px}.pages span:last-child,.pages a:last-child{border-width:1px 0 1px 1px;border-bottom-left-radius:3px;border-top-left-radius:3px}.pages .inactive,.pages .currentPage,.pages a{border-width:1px 0 1px 1px;float:right}.pages a[rel='last']{border-bottom-left-radius:3px;border-top-left-radius:3px}.close{left:auto}.alert .closebtn{left:-21px}.closebtn{float:left}#logo{float:right!important}.floating{-webkit-box-shadow:0 0 2px 3px rgba(0,0,0,0.4);box-shadow:0 0 2px 3px rgba(0,0,0,0.4)}.table .sorting_asc{padding-left:19px;background:url("../images/asc.gif") no-repeat scroll left center #ecede6}.table .sorting_desc{padding-left:19px;background:url("../images/desc.gif") no-repeat scroll left center #ecede6}.table .sorting{padding-left:19px;background:url("../images/ascdesc.gif") no-repeat scroll left center #ecede6}.table .nosort,.table .nosort.sorting_asc,.table .nosort.sorting_desc,.table .nosort.sorting{padding-left:19px}.tags ul{margin-right:0}.coverimages{float:left}#i18nMenu{margin-right:1em}#overdrive-results{padding-right:1em}.navbar .pull-right{float:left}
>\ No newline at end of file
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less b/koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less
>index fc56f4e..d2d75b8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less
>+++ b/koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less
>@@ -552,4 +552,10 @@ span.sep {
> 
> #overdrive-results {
>     padding-right: 1em;
>+}
>+
>+.navbar {
>+    .pull-right {
>+        float : left;
>+    }
> }
>\ No newline at end of file
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11411: 23615 | 23616 | 23617 | 23883 | 24903 | 25090 | 25131 | 25132