Bugzilla – Attachment 24974 Details for
Bug 11663
Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-11663-Bootstap-opac-holding-tab-improperly-displ.patch (text/plain), 2.41 KB, created by
Frédéric Demians
on 2014-02-01 08:53:56 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2014-02-01 08:53:56 UTC
Size:
2.41 KB
patch
obsolete
>From adbeba0007470cb79da27b0c8e51bda5160579f8 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Sat, 1 Feb 2014 09:49:38 +0100 >Subject: [PATCH] [Bug 11663] Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled > >Bootstap theme opac holding tab is improperly displayed when opacbookbag >syspref is disabled, and virtualshelf is enabled. This is due to the fact that >in this situation basket.js is loaded (for virtual shelves), but some JS >variables are not defined in template since opacbookbag is disabled. > >To reproduce this bug: > >- Choose bootstrap OPAC theme >- Enable virtualsheves syspref >- Disable opacbookbag syspref >- Open a biblio record in OPAC detail page >- You will observe that items holding tabs are not displayed as tabs but > as a buletted list >--- > .../bootstrap/en/includes/opac-bottom.inc | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >index c3ce588..8bb4ccd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >@@ -108,7 +108,7 @@ > //<![CDATA[ > var MSG_CONFIRM_AGAIN = _("Warning: Cannot be undone. Please confirm once again") > var MSG_DELETE_SEARCH_HISTORY = _("Are you sure you want to delete your search history?"); >- [% IF Koha.Preference( 'opacbookbag' ) == 1 %] >+ [% IF Koha.Preference( 'opacbookbag' ) == 1 or Koha.Preference( 'virtualshelves' ) == 1 %] > var MSG_BASKET_EMPTY = _("Your cart is currently empty"); > var MSG_RECORD_IN_BASKET = _("The item is already in your cart"); > var MSG_RECORD_ADDED = _("The item has been added to your cart"); >@@ -122,10 +122,7 @@ > var MSG_ITEM_IN_CART = _("In your cart"); > var MSG_IN_YOUR_CART = _("Items in your cart: "); > var MSG_ITEM_NOT_IN_CART = _("Add to your cart"); >- [% ELSE %] >- [% IF Koha.Preference( 'virtualshelves' ) == 1 %] >- var MSG_NO_RECORD_SELECTED = _("No item was selected"); >- [% END %] >+ var MSG_NO_RECORD_SELECTED = _("No item was selected"); > [% END %] > [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'TagsEnabled' ) == 1 ) %] > var MSG_TAGS_DISABLED = _("Sorry, tags are not enabled on this system."); >-- >1.7.2.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11663
:
24974
|
24978
|
24982