Attachment 24981 Details for Bug 11465 – [PASSED QA] Bug 11465 - Show counts and amounts on OPAC your summary tabs

[patch] [PASSED QA] Bug 11465 - Show counts and amounts on OPAC your summary tabs

PASSED-QA-Bug-11465---Show-counts-and-amounts-on-O.patch (text/plain), 4.00 KB, created by Katrin Fischer on 2014-02-02 11:01:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-02-02 11:01:19 UTC

Size: 4.00 KB

patch

obsolete

>From 1b169651bc463de27d56869fc0d859daae57de69 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 2 Jan 2014 16:48:01 +1100
>Subject: [PATCH] [PASSED QA] Bug 11465 - Show counts and amounts on OPAC your
> summary tabs
>
>This patch adds counts and amounts to the tabs in the 'your summary'
>page of the OPAC patron account.
>
>_TEST PLAN_
>
>Before applying:
>1) Choose a test patron
>2) Place a few holds
>3) Check in one of the holds so that it is waiting for the patron
>4) Check out a few items
>5) Check out another item that can generate fines (backdate it a few weeks/months)
>6) Run fines.pl to generate fines (make sure your finesmode syspref is set to prod)
>7) Check your OPAC patron account.
>8) Note the tabs "Checked out, Fines, Holds, and Waiting"
>
>Apply the patch
>1) Switch your OPAC to the bootstrap theme
>2) Refresh your browser for the OPAC patron account screen
>3) Note that the applicable counts and amounts appear on the tabs
>
>--
>
>At the moment, I just have a Bootstrap patch. This is an easy patch though, so
>I can duplicate to the other themes if necessary...
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>All tests on bootstrap pass
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests and QA script pass.
>"Waiting" doesn't appear to work for me with and without the patch.
>"Checkouts", "Holds" and "Fines" work fine.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index a16dc47..48d06cc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -82,15 +82,15 @@
> 
>                     <div id="opac-user-views" class="toptabs">
>                         <ul>
>-                            <li><a href="#opac-user-checkouts">Checked out</a></li>
>-                            [% IF ( overdues_count ) %]<li><a href="#opac-user-overdues">Overdue</a></li>[% END %]
>+                            <li><a href="#opac-user-checkouts">Checked out ([% issues_count %])</a></li>
>+                            [% IF ( overdues_count ) %]<li><a href="#opac-user-overdues">Overdue ([% overdues_count %])</a></li>[% END %]
>                             [% IF ( OPACFinesTab ) %]
>-                                [% IF ( BORROWER_INF.amountoverfive ) %]<li><a href="#opac-user-fines">Fines</a></li>[% END %]
>-                                [% IF ( BORROWER_INF.amountoverzero ) %]<li><a href="#opac-user-fines">Fines</a></li>[% END %]
>-                                [% IF ( BORROWER_INF.amountlessthanzero ) %]<li><a href="#opac-user-fines">Credits</a></li>[% END %]
>+                                [% IF ( BORROWER_INF.amountoverfive ) %]<li><a href="#opac-user-fines">Fines ([% BORROWER_INF.amountoutstanding %])</a></li>[% END %]
>+                                [% IF ( BORROWER_INF.amountoverzero ) %]<li><a href="#opac-user-fines">Fines ([% BORROWER_INF.amountoutstanding %])</a></li>[% END %]
>+                                [% IF ( BORROWER_INF.amountlessthanzero ) %]<li><a href="#opac-user-fines">Credits ([% BORROWER_INF.amountoutstanding %])</a></li>[% END %]
>                             [% END %]
>-                            [% IF ( waiting_count ) %][% IF ( BORROWER_INF.atdestination ) %]<li><a href="#opac-user-waiting">Waiting</a></li>[% END %][% END %]
>-                            [% IF ( reserves_count ) %]<li><a href="#opac-user-holds">Holds</a></li>[% END %]
>+                            [% IF ( waiting_count ) %][% IF ( BORROWER_INF.atdestination ) %]<li><a href="#opac-user-waiting">Waiting ([% waiting_count %])</a></li>[% END %][% END %]
>+                            [% IF ( reserves_count ) %]<li><a href="#opac-user-holds">Holds ([% reserves_count %])</a></li>[% END %]
>                         </ul>
> 
>                         <div id="opac-user-checkouts">
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11465: 23888 | 24951 | 24981