Bugzilla – Attachment 25141 Details for
Bug 8918
ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8918: Add a unit test for CalculatePriority
Bug-8918-Add-a-unit-test-for-CalculatePriority.patch (text/plain), 1.60 KB, created by
Kyle M Hall (khall)
on 2014-02-07 16:25:33 UTC
(
hide
)
Description:
Bug 8918: Add a unit test for CalculatePriority
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-02-07 16:25:33 UTC
Size:
1.60 KB
patch
obsolete
>From 8c9dee7617854fd8f52593f0ad122150d4a53125 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 5 Nov 2013 16:25:56 +0100 >Subject: [PATCH] Bug 8918: Add a unit test for CalculatePriority > >Rebased on January 29, 2014 (marcelr) >Added text on the two 'is'-statements. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Reserves.t | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index db82296..7f43986 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -2,7 +2,7 @@ > > use Modern::Perl; > >-use Test::More tests => 23; >+use Test::More tests => 25; > use MARC::Record; > use DateTime::Duration; > >@@ -317,6 +317,16 @@ ModReserveAffect( $itemnumber, $requesters{'CPL'} , 0); #confirm hold > is(defined $results[3]?1:0, 1, 'GetReservesFromItemnumber returns a future wait (confirmed future hold)'); > # End of tests for bug 9788 > >+# Tests for CalculatePriority (bug 8918) >+my $p = C4::Reserves::CalculatePriority($bibnum2); >+is($p, 4, 'CalculatePriority should now return priority 4'); >+AddReserve('CPL', $requesters{'CPL'}, $bibnum2, >+ $constraint, $bibitems, $p, undef, $expdate, $notes, >+ $title, $checkitem, $found); >+$p = C4::Reserves::CalculatePriority($bibnum2); >+is($p, 5, 'CalculatePriority should now return priority 5'); >+# End of tests for bug 8918 >+ > $dbh->rollback; > > sub count_hold_print_messages { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8918
:
12810
|
13472
|
13565
|
15435
|
17376
|
17881
|
17882
|
17888
|
17889
|
17890
|
21328
|
21329
|
21330
|
22731
|
22732
|
24863
|
24864
|
24880
|
24881
|
24882
|
24883
|
24884
|
24885
|
24886
|
24887
|
24888
|
24920
|
25080
|
25081
|
25082
|
25083
|
25084
|
25118
|
25119
|
25139
|
25140
| 25141 |
25142
|
25143
|
25144