Attachment 25144 Details for Bug 8918 – Bug 8918: Follow-up for use of AddBiblio in Reserves.t with UNIMARC

[patch] Bug 8918: Follow-up for use of AddBiblio in Reserves.t with UNIMARC

Bug-8918-Follow-up-for-use-of-AddBiblio-in-Reserve.patch (text/plain), 1.67 KB, created by Kyle M Hall (khall) on 2014-02-07 16:25:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-02-07 16:25:52 UTC

Size: 1.67 KB

patch

obsolete

>From 0e1bf697b8988931dd02e182c647e8a15d335476 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 7 Feb 2014 12:05:24 +0100
>Subject: [PATCH] Bug 8918: Follow-up for use of AddBiblio in Reserves.t with UNIMARC
>
>Changed title and author field for UNIMARC.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Tested for MARC21, NORMARC and UNIMARC by adding temporary set_preference..
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Reserves.t |   18 ++++++++++++------
> 1 files changed, 12 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 1ea6f82..4b0058c 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -46,13 +46,19 @@ foreach my $addcat ('S', 'PT') {
> diag("\nCreating biblio instance for testing.");
> my $bib = MARC::Record->new();
> my $title = 'Silence in the library';
>-$bib->append_fields(
>-    MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
>-    MARC::Field->new('245', ' ', ' ', a => $title),
>-);
>+if( C4::Context->preference('marcflavour') eq 'UNIMARC' ) {
>+    $bib->append_fields(
>+        MARC::Field->new('600', '', '1', a => 'Moffat, Steven'),
>+        MARC::Field->new('200', '', '', a => $title),
>+    );
>+}
>+else {
>+    $bib->append_fields(
>+        MARC::Field->new('100', '', '', a => 'Moffat, Steven'),
>+        MARC::Field->new('245', '', '', a => $title),
>+    );
>+}
> my ($bibnum, $bibitemnum);
>-# If marcflavour is UNIMARC, AddBiblio fails and all following tests fail too.
>-C4::Context->set_preference('marcflavour', 'MARC21');
> ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');
> 
> # Helper item for that biblio.
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8918: 12810 | 13472 | 13565 | 15435 | 17376 | 17881 | 17882 | 17888 | 17889 | 17890 | 21328 | 21329 | 21330 | 22731 | 22732 | 24863 | 24864 | 24880 | 24881 | 24882 | 24883 | 24884 | 24885 | 24886 | 24887 | 24888 | 24920 | 25080 | 25081 | 25082 | 25083 | 25084 | 25118 | 25119 | 25139 | 25140 | 25141 | 25142 | 25143 | 25144