Attachment 25169 Details for Bug 11680 – Bug 11680: (follow-up) tax rate changes on edit

[patch] Bug 11680: (follow-up) tax rate changes on edit

0002-Bug-11680-follow-up-tax-rate-changes-on-edit.patch (text/plain), 1.43 KB, created by Jacek Ablewicz on 2014-02-10 09:28:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jacek Ablewicz

Created: 2014-02-10 09:28:57 UTC

Size: 1.43 KB

patch

obsolete

>From d40ef78e9200a07ec4a3e82ffae5ac7d7115fffd Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Mon, 10 Feb 2014 10:09:21 +0100
>Subject: [PATCH 2/2] Bug 11680: (follow-up) tax rate changes on edit
>
>Follow-up to fix similar issue on vendor edit.
>
>If the tax rates in Acquisitions -> gist system preference
>are entered with trailing zeroes, given vendor tax rate value
>may not be correctly handled on vendor edit.
>
>Test plan for this follow-up:
>
>1) insert some tax rates with trailing zeroes in gist
>system preference (e.g: '0|0.080|0.12|0.20|0.23')
>2) add some vendors, choosing 8.0% 12.0% 20.0% 23.0%
>as gst rate
>3) try to modify them
>4) note that vendors with 12.0% and 23.0% tax rates are
>preserving previously choosen rates on edit, while
>the ones with 8.0% and 20.0% do not (they are defaulting
>to the first defined tax rate)
>5) apply the patch
>6) repeat 2) and 3)
>7) all tax rates configured in system prefrence shall now
>behave properly while editing vendors
>---
> acqui/supplier.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/acqui/supplier.pl b/acqui/supplier.pl
>index df417c0..86aad0a 100755
>--- a/acqui/supplier.pl
>+++ b/acqui/supplier.pl
>@@ -137,7 +137,7 @@ if ( $op eq 'display' ) {
> 
>     # get option values from gist syspref
>     my @gst_values = map {
>-        option => $_
>+        option => $_ + 0.0
>     }, split( '\|', C4::Context->preference("gist") );
> 
>     $template->param(
>-- 
>1.7.10.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 11680: 25048 | 25059 | 25155 | 25169 | 26452 | 26453