Bugzilla – Attachment 25173 Details for
Bug 11509
koha-create should print better usage information
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11509: (trivial rmaint followup) wrong parameter count
Bug-11509-trivial-rmaint-followup-wrong-parameter-.patch (text/plain), 1.51 KB, created by
Tomás Cohen Arazi (tcohen)
on 2014-02-10 14:59:42 UTC
(
hide
)
Description:
Bug 11509: (trivial rmaint followup) wrong parameter count
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-02-10 14:59:42 UTC
Size:
1.51 KB
patch
obsolete
>From d70a268d07851597fb4db17355bf3e9c32e13389 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Mon, 10 Feb 2014 11:55:06 -0300 >Subject: [PATCH] Bug 11509: (trivial rmaint followup) wrong parameter count > >While adding the --help and -h switches I forgot to change to arguments >count validation so that one can actually use those parameters (i.e. koha-create >should accept being invoked with only one parameter). > >This patch just changes the minimum parateres required from 2 to 1. > >To reproduce: >- Run 'koha-create --help' from master >=> Usage information is printed BUT ALSO an "Error: wrong parameters" message >- Apply the patch and >- Run 'koha-create --help' >=> Usage informatio it printed and no error message. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > debian/scripts/koha-create | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create >index c277f08..826163c 100755 >--- a/debian/scripts/koha-create >+++ b/debian/scripts/koha-create >@@ -254,7 +254,7 @@ then > . /etc/koha/koha-sites.conf > fi > >-[ $# -ge 2 ] && [ $# -le 16 ] || ( usage ; die "Error: wrong parameters" ) >+[ $# -ge 1 ] && [ $# -le 16 ] || ( usage ; die "Error: wrong parameters" ) > > TEMP=`getopt -o chrpm:l:d:f:b:a: -l create-db,request-db,populate-db,use-db,use-memcached,help,marcflavor:,auth-idx:,biblio-idx:,zebralang:,defaultsql:,configfile:,passwdfile:,database:,adminuser:,memcached-servers:,memcached-prefix:, \ > -n "$0" -- "$@"` >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11509
:
24090
|
24098
|
24205
|
24239
|
24240
| 25173