Attachment 25240 Details for Bug 11757 – Bug 11757: remove dependency on POE

[patch] Bug 11757: remove dependency on POE

Bug-11757-remove-dependency-on-POE.patch (text/plain), 4.71 KB, created by Chris Cormack on 2014-02-14 06:50:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-02-14 06:50:32 UTC

Size: 4.71 KB

patch

obsolete

>From 271d5de01f9f025f3736278e5b81c13d21f2680e Mon Sep 17 00:00:00 2001
>From: Galen Charlton <gmc@esilibrary.com>
>Date: Fri, 14 Feb 2014 00:24:56 +0000
>Subject: [PATCH] Bug 11757: remove dependency on POE
>
>The last use of the POE family of Perl modules went away with
>the removal of zebraqueue_daemon.pl per bug 9001.  Consequently,
>this patch removes POE as a dependency.
>
>To test:
>
>[1] Verify that "git grep POE" and "git grep libpoe" report
>    nothing.
>[2] Verify that koha_perl_deps.pl -a does not report POE
>    as a dependency.
>[3] (extra credit) verify that Debian packages can be built
>    that do not list libpoe-perl as a dependency.
>
>This patch also updates some distro-specific installation
>instructions and scripts, but makes no representations about
>whether those instructions currently work.
>
>Signed-off-by: Galen Charlton <gmc@esilibrary.com>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> C4/Installer/PerlDependencies.pm   | 5 -----
> INSTALL.fedora7                    | 1 -
> INSTALL.opensuse                   | 1 -
> debian/control                     | 2 --
> install_misc/debian.packages       | 1 -
> install_misc/ubuntu.10.04.packages | 1 -
> install_misc/ubuntu.12.04.packages | 1 -
> install_misc/ubuntu.packages       | 1 -
> 8 files changed, 13 deletions(-)
>
>diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm
>index 9b4b3b6..829660f 100644
>--- a/C4/Installer/PerlDependencies.pm
>+++ b/C4/Installer/PerlDependencies.pm
>@@ -89,11 +89,6 @@ our $PERL_DEPS = {
>         'required' => '1',
>         'min_ver'  => '1.59'
>     },
>-    'POE' => {
>-        'usage'    => 'Core',
>-        'required' => '1',
>-        'min_ver'  => '0.9999'
>-    },
>     'Email::Date' => {
>         'usage'    => 'Core',
>         'required' => '1',
>diff --git a/INSTALL.fedora7 b/INSTALL.fedora7
>index aa0f97f..465e706 100644
>--- a/INSTALL.fedora7
>+++ b/INSTALL.fedora7
>@@ -774,7 +774,6 @@ XML::LibXSLT
> XML::Simple
> YAML::Syck
> Unix::Syslog
>-POE
> Date::Calc
> CHI
> CHI::Driver::Memcached
>diff --git a/INSTALL.opensuse b/INSTALL.opensuse
>index 615e9a7..7784d6e 100644
>--- a/INSTALL.opensuse
>+++ b/INSTALL.opensuse
>@@ -857,7 +857,6 @@ The commands show below need to be given one by one, because zypper will always
> # zypper install perl-PDF-API2
> # zypper install perl-PDF-Reuse
> # zypper install perl-PDF-Reuse-Barcode
>-# zypper install perl-POE
> # zypper install perl-32bit
> # zypper install perl-SMS-Send
> # zypper install perl-Schedule-At
>diff --git a/debian/control b/debian/control
>index 789b534..695a3d4 100644
>--- a/debian/control
>+++ b/debian/control
>@@ -83,7 +83,6 @@ Build-Depends: libalgorithm-checkdigits-perl,
>  libpdf-reuse-barcode-perl,
>  libpdf-reuse-perl,
>  libpdf-table-perl,
>- libpoe-perl,
>  libreadonly-perl,
>  libreadonly-xs-perl,
>  libscalar-list-utils-perl,
>@@ -272,7 +271,6 @@ Depends: libalgorithm-checkdigits-perl,
>  libpdf-reuse-barcode-perl,
>  libpdf-reuse-perl,
>  libpdf-table-perl,
>- libpoe-perl,
>  libreadonly-perl,
>  libreadonly-xs-perl,
>  libscalar-list-utils-perl,
>diff --git a/install_misc/debian.packages b/install_misc/debian.packages
>index 1e92c74..9c31206 100644
>--- a/install_misc/debian.packages
>+++ b/install_misc/debian.packages
>@@ -94,7 +94,6 @@ libpdf-api2-simple-perl install
> libpdf-reuse-barcode-perl install
> libpdf-reuse-perl install
> libpdf-table-perl install
>-libpoe-perl	install
> libreadonly-perl    install
> libreadonly-xs-perl    install
> libschedule-at-perl install
>diff --git a/install_misc/ubuntu.10.04.packages b/install_misc/ubuntu.10.04.packages
>index 1d1470e..17cfdc8 100644
>--- a/install_misc/ubuntu.10.04.packages
>+++ b/install_misc/ubuntu.10.04.packages
>@@ -121,7 +121,6 @@ libpdf-api2-simple-perl			install
> libpdf-reuse-barcode-perl		install
> libpdf-reuse-perl			install
> libpdf-table-perl			install
>-libpoe-perl				install
> libreadonly-perl			install
> libreadonly-xs-perl			install
> libschedule-at-perl			install
>diff --git a/install_misc/ubuntu.12.04.packages b/install_misc/ubuntu.12.04.packages
>index df87256..c63aaf3 100644
>--- a/install_misc/ubuntu.12.04.packages
>+++ b/install_misc/ubuntu.12.04.packages
>@@ -126,7 +126,6 @@ libpdf-api2-simple-perl			install
> libpdf-reuse-barcode-perl		install
> libpdf-reuse-perl			install
> libpdf-table-perl			install
>-libpoe-perl				install
> libreadonly-perl			install
> libreadonly-xs-perl			install
> libschedule-at-perl			install
>diff --git a/install_misc/ubuntu.packages b/install_misc/ubuntu.packages
>index 5356e54..aea298e 100644
>--- a/install_misc/ubuntu.packages
>+++ b/install_misc/ubuntu.packages
>@@ -126,7 +126,6 @@ libpdf-api2-simple-perl			install
> libpdf-reuse-barcode-perl		install
> libpdf-reuse-perl			install
> libpdf-table-perl			install
>-libpoe-perl				install
> libreadonly-perl			install
> libreadonly-xs-perl			install
> libschedule-at-perl			install
>-- 
>1.8.5.3

Actions: View | Diff | Splinter Review

Attachments on bug 11757: 25238 | 25240 | 25267