Bugzilla – Attachment 25265 Details for
Bug 11756
Hold ratios report sorting incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11756 - Hold ratios report sorting incorrectly
Bug-11756---Hold-ratios-report-sorting-incorrectly.patch (text/plain), 2.13 KB, created by
Owen Leonard
on 2014-02-14 14:02:06 UTC
(
hide
)
Description:
Bug 11756 - Hold ratios report sorting incorrectly
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-02-14 14:02:06 UTC
Size:
2.13 KB
patch
obsolete
>From 503c185ade64fc72e9efe68461588376dc70f828 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 14 Feb 2014 08:48:46 -0500 >Subject: [PATCH] Bug 11756 - Hold ratios report sorting incorrectly >Content-Type: text/plain; charset="utf-8" > >The DataTables plugin doesn't by default take multiple columns into >account when sorting. The hold ratios report presents a situation where >it makes sense to sort by default based on two columns: hold count and >title, since there are likely to be many titles with the same hold >count. > >This patch adds sorting by default on holds (descending) and title >(ascending). It also modifies the configuration of the title sort to >exclude articles when sorting. > >To test, view the hold ratios report. If necessary use the filter form >to reduce the minimum hold ratio and generate more results. Confirm that >the correct columns can be sorted. > >Note that by default one can manually trigger sorting on two columns by >shift-clicking the second column header. >--- > .../prog/en/modules/circ/reserveratios.tt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >index d55382e..2cc539a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >@@ -17,9 +17,21 @@ > function () { $(this).toggleClass("ulined") } > ); > $("#holdst").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "aaSorting": [ [0,'desc'], [3,'asc'] ], > "aoColumnDefs": [ > { "aTargets": [ 8 ], "sType": "natural" } > ], >+ "aoColumns": [ >+ null, >+ null, >+ null, >+ { "sType": "anti-the" }, >+ null, >+ null, >+ null, >+ null, >+ null >+ ], > "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]], > "iDisplayLength": 20, > "sPaginationType": "four_button" >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11756
:
25237
|
25265
|
25300
|
25374