Attachment 25320 Details for Bug 7567 – Bug 7567 - Undefined $lang triggers warning

[patch] Bug 7567 - Undefined $lang triggers warning

Bug-7567---Undefined-lang-triggers-warning.patch (text/plain), 1.47 KB, created by Chris Cormack on 2014-02-16 21:01:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-02-16 21:01:44 UTC

Size: 1.47 KB

patch

obsolete

>From 877b452eb2c6cd32ceacf6dc0c8e2cf75afb9bb1 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 13 Dec 2013 16:17:04 -0500
>Subject: [PATCH] Bug 7567 - Undefined $lang triggers warning
>
>Changed:
>    $template->param(
>        $lang           => 1,
>        opac_news       => $opac_news,
>        opac_news_count => $opac_news_count,
>                );
>Into:
>    $template->param(
>        opac_news       => $opac_news,
>        opac_news_count => $opac_news_count,
>                );
>    $template->param( $lang => 1 ) if $lang;
>
>Because $lang is not defined when you come immediately into
>Home -> Tools -> News.
>
>TEST PLAN
>---------
>1) log into staff client
>2) Tools -> News
>3) Check koha error log
>   - Expecting to see an error like:
>koha-news.pl: Problem = a value of 1 has been passed to param without key
>4) Apply patch
>5) Home -> Tools -> News
>6) Check koha error log
>   - No error generated
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> tools/koha-news.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/koha-news.pl b/tools/koha-news.pl
>index 8a98c76..fb01195 100755
>--- a/tools/koha-news.pl
>+++ b/tools/koha-news.pl
>@@ -113,9 +113,9 @@ else {
>     }
>     
>     $template->param(
>-        $lang           => 1,
>         opac_news       => $opac_news,
>         opac_news_count => $opac_news_count,
> 		);
>+    $template->param( $lang => 1 ) if $lang;
> }
> output_html_with_http_headers $cgi, $cookie, $template->output;
>-- 
>1.8.5.3

Actions: View | Diff | Splinter Review

Attachments on bug 7567: 22863 | 22917 | 22920 | 23350 | 23351 | 23352 | 23362 | 23368 | 23378 | 23383 | 23386 | 23474 | 23475 | 23501 | 23544 | 23547 | 23552 | 23553 | 23554 | 23559 | 23664 | 23703 | 23704 | 23705 | 25316 | 25317 | 25318 | 25319 | 25320 | 25321 | 25322 | 25323 | 25324 | 25325 | 25331 | 25332 | 25333 | 26510 | 26511 | 26590 | 26591 | 26592 | 26593 | 26594 | 26595 | 26596 | 26597 | 26598 | 26599 | 26600 | 26601 | 26602 | 26603 | 26604 | 26605 | 26606 | 26607 | 26608 | 26609 | 26610 | 26611 | 26612 | 26631 | 26632 | 26633 | 26634 | 26635 | 26636 | 26637 | 26638 | 26639 | 26640 | 26641 | 26642 | 26643 | 26644 | 26647