Attachment 25440 Details for Bug 11783 – Bug 11783 - Record level unavailable holds sending empty CD field rather than item barcode

[patch] Bug 11783 - Record level unavailable holds sending empty CD field rather than item barcode

Bug-11783---Record-level-unavailable-holds-sending.patch (text/plain), 2.01 KB, created by Jonathan Druart on 2014-02-19 11:15:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-02-19 11:15:54 UTC

Size: 2.01 KB

patch

obsolete

>From f828c3476cedca5fd77f053117e2823a7a1ebf52 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 18 Feb 2014 09:47:32 -0500
>Subject: [PATCH] Bug 11783 - Record level unavailable holds sending empty CD
> field rather than item barcode
>
>If a patron has a record-level hold that is unavailable, any patron
>information request will send back an empty CD field when this field
>should have an item barcode in it. This is due to a minor error in
>ILS::Patron::_get_outstanding_hodsl where GetItemnumbersForBiblio is
>assumed to return an array but in reality returns an arrayref.
>
>Test Plan:
>1) Create a record level hold for a patron and record
>2) Using SIP2, make a patron information request
>3) Note the empty CD fields
>4) Apply this patch, restart SIP server
>5) Repeat step 2
>6) Note the CD field now has a barcode
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>I did not test this patch but the following code shows me it is correct:
>  use C4::Items;
>  use Data::Dumper;
>  my $biblionumber = 5035;
>  my $itemnumber = (GetItemnumbersForBiblio($biblionumber))[0];
>  say Dumper $itemnumber;
>  $itemnumber = (GetItemnumbersForBiblio($biblionumber))->[0];
>  say Dumper $itemnumber;
>
>displays:
>
>$VAR1 = [
>          '23168',
>          '23169',
>          '23170',
>          '23171',
>          '23172'
>        ];
>
>$VAR1 = '23168';
>---
> C4/SIP/ILS/Patron.pm |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
>index 5b835ca..4ccd21b 100644
>--- a/C4/SIP/ILS/Patron.pm
>+++ b/C4/SIP/ILS/Patron.pm
>@@ -402,7 +402,7 @@ sub _get_outstanding_holds {
>         else {
>             # We need to return a barcode for the biblio so the client
>             # can request the biblio info
>-            $item = ( GetItemnumbersForBiblio($h->{biblionumber}) )[0];
>+            $item = ( GetItemnumbersForBiblio($h->{biblionumber}) )->[0];
>         }
>         $h->{barcode} = GetBarcodeFromItemnumber($item);
>     }
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11783: 25375 | 25403 | 25440