Bugzilla – Attachment 25529 Details for
Bug 11799
Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm
Bug-11799-Housekeeping-Remove-biblionumbersth-from.patch (text/plain), 1.30 KB, created by
Jonathan Druart
on 2014-02-21 08:11:39 UTC
(
hide
)
Description:
Bug 11799: Housekeeping: Remove _biblionumber_sth from VirtualShelves.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-02-21 08:11:39 UTC
Size:
1.30 KB
patch
obsolete
>From f83b4d30e29569008ba7e1ba5db4d0d014a045c0 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 20 Feb 2014 12:54:32 +0100 >Subject: [PATCH] Bug 11799: Housekeeping: Remove _biblionumber_sth from > VirtualShelves.pm >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This routine is no longer used. > >Test plan: >Do a grep on the name. >(Bonus points:) Verify if you can perform some actions on lists. > >No more occurences of _biblionumber_sth found >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/VirtualShelves.pm | 11 ----------- > 1 file changed, 11 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 38fa0e8..7ab875e 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -666,17 +666,6 @@ sub _shelf_count { > return $total; > } > >-sub _biblionumber_sth { #only used in obsolete sub below >- my ($shelf) = @_; >- my $query = 'select biblionumber from virtualshelfcontents where shelfnumber = ?'; >- my $dbh = C4::Context->dbh; >- my $sth = $dbh->prepare($query) >- or die $dbh->errstr; >- $sth->execute( $shelf ) >- or die $sth->errstr; >- $sth; >-} >- > sub _CheckShelfName { > my ($name, $cat, $owner, $number)= @_; > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11799
:
25496
|
25518
| 25529