Attachment 25550 Details for Bug 11819 – Bug 11819 - Don't show catalog edit menu if user has no edit permissions

[patch] Bug 11819 - Don't show catalog edit menu if user has no edit permissions

Bug-11819---Dont-show-catalog-edit-menu-if-user-ha.patch (text/plain), 1.96 KB, created by Owen Leonard on 2014-02-21 19:57:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-02-21 19:57:01 UTC

Size: 1.96 KB

patch

obsolete

>From 373ff22fad2870a355c35624014232331f44121b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 21 Feb 2014 14:52:22 -0500
>Subject: [PATCH] Bug 11819 - Don't show catalog edit menu if user has no edit
> permissions
>Content-Type: text/plain; charset="utf-8"
>
>Currently if the logged in user lacks any cataloging permissions the
>bibliographic detail page (catalogue/detail.pl) still shows the Edit
>button, but with an empty dropdown menu. This patch corrects the toolbar
>include so that the button will not appear at all.
>
>To test, view the biblio detail page as a user with various combinations
>of the following permissions:
>
>- edit_items
>- edit_catalogue
>- items_batchmod
>- items_batchdel
>
>The edit button should appear with the correct set of links when the
>user has any combination of the above permissions. If user has none the
>button should not appear.
>---
> .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index 63b22a4..e2271df 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -149,6 +149,7 @@ CAN_user_serials_create_subscription ) %]
>     </div>
> [% END %]
> 
>+[% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items || CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel ) %]
>     <div class="btn-group">
>     <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-pencil"></i> Edit <span class="caret"></span></button>
>         <ul class="dropdown-menu">
>@@ -184,6 +185,7 @@ CAN_user_serials_create_subscription ) %]
> 
>     </ul>
>     </div>
>+[% END %]
> 
>     <div class="btn-group">
>     <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-download-alt"></i> Save <span class="caret"></span></button>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11819: 25550 | 25557 | 25564