Bugzilla – Attachment 25576 Details for
Bug 11803
Consistent use of $dbh in _koha_modify_item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11803: Consistent use of $dbh in _koha_modify_item
Bug-11803-Consistent-use-of-dbh-in-kohamodifyitem.patch (text/plain), 1.34 KB, created by
Jonathan Druart
on 2014-02-24 12:09:30 UTC
(
hide
)
Description:
Bug 11803: Consistent use of $dbh in _koha_modify_item
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-02-24 12:09:30 UTC
Size:
1.34 KB
patch
obsolete
>From 75228fb8b2b9ae05ebdab496efd554c54e99441a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 20 Feb 2014 19:39:10 +0100 >Subject: [PATCH] Bug 11803: Consistent use of $dbh in _koha_modify_item >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This is just some code cleanup, no behavior change expected. >Also replacing errstr with err in testing the results. (See DBI.) > >Test plan: >Modify an item and save it. > >Followed test plan. No problems found. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Items.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 5680db7..12dce85 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2316,10 +2316,10 @@ sub _koha_modify_item { > $query =~ s/,$//; > $query .= " WHERE itemnumber=?"; > push @bind, $item->{'itemnumber'}; >- my $sth = C4::Context->dbh->prepare($query); >+ my $sth = $dbh->prepare($query); > $sth->execute(@bind); >- if ( C4::Context->dbh->errstr ) { >- $error.="ERROR in _koha_modify_item $query".$dbh->errstr; >+ if ( $sth->err ) { >+ $error.="ERROR in _koha_modify_item $query: ".$sth->errstr; > warn $error; > } > return ($item->{'itemnumber'},$error); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11803
:
25519
|
25561
| 25576