Attachment 25602 Details for Bug 11798 – [SIGNED OFF] Bug 11798 - Problems with column sorting and row visibility in invoices table

[patch] [SIGNED OFF] Bug 11798 - Problems with column sorting and row visibility in invoices table

SIGNED-OFF-Bug-11798---Problems-with-column-sortin.patch (text/plain), 2.40 KB, created by Mark Tompsett on 2014-02-25 06:18:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-02-25 06:18:30 UTC

Size: 2.40 KB

patch

obsolete

>From 4a03416cfd65874e14b3d2bbf7907cee82fe101d Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Thu, 20 Feb 2014 09:53:23 +0100
>Subject: [PATCH] [SIGNED OFF] Bug 11798 - Problems with column sorting and
> row visibility in invoices table
>
>1) Sorting on "Billing date" (functionality introduced by bug 10794)
>doesn't work properly any longer after bug 10401 was pushed (another
>side-effect being that "Vendor" column is currently not sortable
>at all).
>2) Only "top ten" invoices are always displayed in the table, and it's
>not possible to change that without missing top/bottom DataTables
>pagination bars.
>
>This patch fixes sorting for "Billing date" &  "Vendor" columns
>in invoices table and restores the ability to see all table
>rows/search results (not just "top ten").
>
>Test plan (you'll need to have 11+ invoices with various billing
>dates entered in the system):
>1) apply patch,
>2) view the Acquisitions invoices page (acqui/invoices.pl), do some
>search (= as broad search as possible) and confirm that "Billing
>date" and "Vendor" columns now do sort correctly,
>3) in situations when there are more then 10 search results, they
>should all be visible in the invoices table.
>
>NOTE: Generating invoices is a painfully convoluted mess.
>      All my "Billing date" entries were blank, so was not
>      able to confirm Billing date issues. However, Vendor
>      sorting issues, seeing more than 10, and in my bizarre
>      initial case the non-visible checkboxes were all fixed.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../prog/en/modules/acqui/invoices.tt              |    5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>index 66b40a6..b7d9399 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>@@ -11,8 +11,11 @@
> $(document).ready(function() {
>     $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, {
>         sDom: "t",
>+        bPaginate: false,
>+        bFilter: false,
>+        bInfo: false,
>         "aoColumns": [
>-            null,null,{ "sType": "title-string" },null,null,null,null
>+            null,null,null,{ "sType": "title-string" },null,null,null,null
>         ],
>         aoColumnDefs: [
>             { "bSortable": false, "aTargets": [0, 7] }
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11798: 25479 | 25602 | 25611