Bugzilla – Attachment 25617 Details for
Bug 11741
< > not displaying correctly in XSLT result list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11741: Correct display of < > in XSLT result lists
Bug-11741-Correct-display-of---in-XSLT-result-list.patch (text/plain), 1.75 KB, created by
Tomás Cohen Arazi (tcohen)
on 2014-02-25 13:49:37 UTC
(
hide
)
Description:
Bug 11741: Correct display of < > in XSLT result lists
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-02-25 13:49:37 UTC
Size:
1.75 KB
patch
obsolete
>From 8ed4b797fb43b2fcdafb5ead5a58ad74acfd4bcc Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Tue, 11 Feb 2014 16:29:13 +0100 >Subject: [PATCH] Bug 11741: Correct display of < > in XSLT result lists > >< and > are incorrectly transformed into HTML entities on the >XSLT result list. > >Example: >Record: <TEST> >Result list: <TEST> >HTML source: &lt;TEST&gt > >To test: >- catalog a record that contains > and < >- Reindex, without using the -x option >- Confirm the display is correct >- Reindex again, using the -x option >- Confirm the display is now broken >- Apply patch >- Reindex again with and without -x >- Verify that now the display is always correct > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >Note: the problem is only visible in GRS-1 setup. It works as expected. >No behaviour change in DOM. >I belive we shouldn't be (de)escaping data ad-hoc, but it seems that GRS-1 >needs it because it doesn't handle HTML entities properly. This fix is OK for >GRS-1, unneeded for DOM and probably any other modern search engine. >--- > C4/XSLT.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/XSLT.pm b/C4/XSLT.pm >index d85b048..163b5a4 100644 >--- a/C4/XSLT.pm >+++ b/C4/XSLT.pm >@@ -215,8 +215,10 @@ sub XSLTParse4Display { > } > $sysxml .= "</sysprefs>\n"; > $xmlrecord =~ s/\<\/record\>/$itemsxml$sysxml\<\/record\>/; >- if ($fixamps) { # We need to correct the ampersand entities that Zebra outputs >+ if ($fixamps) { # We need to correct the HTML entities that Zebra outputs > $xmlrecord =~ s/\&amp;/\&/g; >+ $xmlrecord =~ s/\&\;lt\;/\<\;/g; >+ $xmlrecord =~ s/\&\;gt\;/\>\;/g; > } > $xmlrecord =~ s/\& /\&\; /; > $xmlrecord =~ s/\&\;amp\; /\&\; /; >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11741
:
25199
|
25617
|
26106