Attachment 25696 Details for Bug 11689 – Bug 11689: Remove warning launching unit tests

[patch] Bug 11689: Remove warning launching unit tests

Bug-11689-Remove-warning-launching-unit-tests.patch (text/plain), 2.15 KB, created by Jonathan Druart on 2014-02-27 12:19:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-02-27 12:19:04 UTC

Size: 2.15 KB

patch

obsolete

>From aabc8f786fe48d8bca897c9b7fe055b81cdcd58e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 27 Feb 2014 13:12:40 +0100
>Subject: [PATCH] Bug 11689: Remove warning launching unit tests
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/Serials.pm            |    8 +++++---
> t/db_dependent/Serials.t |   10 ++++++++--
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index bfbf21f..04935a0 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -2548,10 +2548,12 @@ sub GetNextDate {
>         # irreg1;irreg2;irreg3
>         # where irregX is the number of issue which will not be received
>         # (the first issue takes the number 1, the 2nd the number 2 and so on)
>-        my @irreg = split /;/, $subscription->{'irregularity'} ;
>         my %irregularities;
>-        foreach my $irregularity (@irreg) {
>-            $irregularities{$irregularity} = 1;
>+        if ( $subscription->{irregularity} ) {
>+            my @irreg = split /;/, $subscription->{'irregularity'} ;
>+            foreach my $irregularity (@irreg) {
>+                $irregularities{$irregularity} = 1;
>+            }
>         }
> 
>         # Get the 'fictive' next issue number
>diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t
>index a363999c..f1f5d9d 100644
>--- a/t/db_dependent/Serials.t
>+++ b/t/db_dependent/Serials.t
>@@ -41,7 +41,7 @@ my ($biblionumber, $biblioitemnumber) = AddBiblio(MARC::Record->new, '');
> my $budgetid;
> my $bpid = AddBudgetPeriod({
>     budget_period_startdate => '01-01-2015',
>-    budget_period_enddate   => '12-31-2015',
>+    budget_period_enddate   => '31-12-2015',
>     budget_description      => "budget desc"
> });
> 
>@@ -58,7 +58,13 @@ my $budget_id = AddBudget({
> my $frequency_id = AddSubscriptionFrequency({ description => "Test frequency 1" });
> my $pattern_id = AddSubscriptionNumberpattern({
>     label => 'Test numberpattern 1',
>-    numberingmethod => '{X}'
>+    numberingmethod => '{X}',
>+    label1 => q{},
>+    add1 => 1,
>+    every1 => 1,
>+    every1 => 1,
>+    numbering1 => 1,
>+    whenmorethan1 => 1,
> });
> 
> my $subscriptionid = NewSubscription(
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11689: 25047 | 25308 | 25537 | 25538 | 25631 | 25695 | 25696 | 26389 | 26390 | 26391 | 26392