Attachment 25699 Details for Bug 11866 – Bug 11866 - Staff side course reserves too restrictive

[patch] Bug 11866 - Staff side course reserves too restrictive

Bug-11866---Staff-side-course-reserves-too-restric.patch (text/plain), 3.75 KB, created by Kyle M Hall (khall) on 2014-02-27 13:57:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-02-27 13:57:04 UTC

Size: 3.75 KB

patch

obsolete

>From 516aeb87006f4bd4713baca2775919de1302c045 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 27 Feb 2014 08:55:22 -0500
>Subject: [PATCH] Bug 11866 - Staff side course reserves too restrictive
>
>A librarian with no course reserves permissions cannot view course
>reserves from the staff intranet, yet can from the OPAC. This doesn't
>make much sense. Librarians should not require any course reserves
>permissions to view courses and reserves from the staff intranet.
>
>Test Plan:
>1) Log into staff intranet as a librarian with no course reserves
>   permissions
>2) Note you cannot view course reserves
>3) Apply this patch
>4) Note you can now view course reserves
>5) Verify you cannot modify courses or course reserves
>---
> course_reserves/course-reserves.pl                 |    1 -
> .../intranet-tmpl/prog/en/includes/header.inc      |    2 --
> .../en/modules/course_reserves/course-details.tt   |    8 ++++----
> 3 files changed, 4 insertions(+), 7 deletions(-)
>
>diff --git a/course_reserves/course-reserves.pl b/course_reserves/course-reserves.pl
>index b81bc94..4aa982a 100755
>--- a/course_reserves/course-reserves.pl
>+++ b/course_reserves/course-reserves.pl
>@@ -35,7 +35,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>         query           => $cgi,
>         type            => "intranet",
>         authnotrequired => 0,
>-        flagsrequired   => { coursereserves => '*' },
>     }
> );
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>index b6bc660..a3489c3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
>@@ -22,9 +22,7 @@
>                             [% IF ( CAN_user_serials ) %]
>                             <li><a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a></li>
>                             [% END %]
>-                            [% IF ( CAN_user_coursereserves ) %]
>                             <li><a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a></li>
>-                            [% END %]
>                             [% IF ( CAN_user_reports ) %]
>                             <li><a href="/cgi-bin/koha/reports/reports-home.pl">Reports</a></li>
>                             [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index 5e69702..ea58136 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -17,7 +17,7 @@
>             "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]],
>             "iDisplayLength": 20,
>             "aoColumnDefs": [
>-                { 'bSortable': false, 'aTargets': [ 9, 10, 11 ] }
>+                { 'bSortable': false, 'aTargets': [ 'NoSort' ] }
>             ]
>         }));
> 
>@@ -82,9 +82,9 @@
>                         <th>Library</th>
>                         <th>Staff note</th>
>                         <th>Public note</th>
>-                        [% IF CAN_user_coursereserves_add_reserves %]<th>&nbsp;</th>[% END %]
>-                        [% IF CAN_user_coursereserves_delete_reserves %]<th>&nbsp;</th>[% END %]
>-                        <th>Other course reserves</th>
>+                        [% IF CAN_user_coursereserves_add_reserves %]<th class="NoSort">&nbsp;</th>[% END %]
>+                        [% IF CAN_user_coursereserves_delete_reserves %]<th class="NoSort">&nbsp;</th>[% END %]
>+                        <th class="NoSort">Other course reserves</th>
>                     </tr>
>                 </thead>
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11866: 25699 | 25863 | 25864 | 25948 | 26010 | 26011