Attachment 25701 Details for Bug 11868 – Bug 11868: MTT: disable sms and phone if not in use

[patch] Bug 11868: MTT: disable sms and phone if not in use

Bug-11868-MTT-disable-sms-and-phone-if-not-in-use.patch (text/plain), 3.83 KB, created by Jonathan Druart on 2014-02-27 14:09:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-02-27 14:09:58 UTC

Size: 3.83 KB

patch

obsolete

>From 0227dfeb185596ae646cae1c6037c03f69c13b04 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 27 Feb 2014 14:30:50 +0100
>Subject: [PATCH] Bug 11868: MTT: disable sms and phone if not in use
>
>On both pages "Notices and slips" and "Overdue rules", it would be great
>to disable sms and phone if there are not in use.
>
>Test plan:
>1/ Edit a notice
>2/ Enable/disable the SMSSendDriver pref and verify the sms block is
>enabled/disabled.
>3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
>the phone block is enabled/disabled.
>
>4/ Go on tools/overdues.pl
>5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes
>are enabled/disabled.
>6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
>the phone checkboxes are enabled/disabled.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt      |   10 +++++++++-
> .../intranet-tmpl/prog/en/modules/tools/overduerules.tt      |    8 +++++++-
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index 92c3421..d20c191 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -291,7 +291,15 @@ $(document).ready(function() {
> 
>         [% FOREACH letter IN letters %]
>           <li>
>-            <fieldset class="rows mtt" id="[% letter.message_transport_type %]">
>+            [% IF letter.message_transport_type == "sms" and not Koha.Preference("SMSSendDriver") %]
>+              <fieldset class="rows mtt" id="[% letter.message_transport_type %]" disabled="disabled">
>+                <div class="dialog message">You should enable the SMSSendDriver preference to use the sms templates.</div>
>+            [% ELSIF letter.message_transport_type == "phone" and not Koha.Preference("TalkingTechItivaPhoneNotification") %]
>+              <fieldset class="rows mtt" id="[% letter.message_transport_type %]" disabled="disabled">
>+                <div class="dialog message">You should enable the TalkingTechItivaPhoneNotification preference to use the phone templates.</div>
>+            [% ELSE %]
>+              <fieldset class="rows mtt" id="[% letter.message_transport_type %]">
>+            [% END %]
>               <legend>
>                 [% SWITCH letter.message_transport_type %]
>                 [% CASE 'email' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>index dd90499..63a29e1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
>@@ -146,7 +146,13 @@ $(document).ready(function() {
>                   [% IF mtt.selected %]
>                     <input type="checkbox" name="mtt[% tab.number %]-[% value.overduename %]" value="[% mtt.value %]" checked="checked" />
>                   [% ELSE %]
>-                    <input type="checkbox" name="mtt[% tab.number %]-[% value.overduename %]" value="[% mtt.value %]" />
>+                    [% IF mtt.value == "sms" and not Koha.Preference("SMSSendDriver") %]
>+                      <input type="checkbox" name="mtt[% tab.number %]-[% value.overduename %]" value="[% mtt.value %]" disabled="disabled" />
>+                    [% ELSIF mtt.value == "phone" and not Koha.Preference("TalkingTechItivaPhoneNotification") %]
>+                      <input type="checkbox" name="mtt[% tab.number %]-[% value.overduename %]" value="[% mtt.value %]" disabled="disabled" />
>+                    [% ELSE %]
>+                      <input type="checkbox" name="mtt[% tab.number %]-[% value.overduename %]" value="[% mtt.value %]" />
>+                    [% END %]
>                   [% END %]
>                 </td>
>               [% END %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11868: 25701 | 25763 | 25764 | 27289