Bugzilla – Attachment 25719 Details for
Bug 11832
JavaScript error on staff client place hold screen if record has no items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 11832 - JavaScript error on staff client place hold screen if record has no items
SIGNED-OFF-Bug-11832---JavaScript-error-on-staff-c.patch (text/plain), 1.77 KB, created by
Mark Tompsett
on 2014-02-28 14:31:35 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 11832 - JavaScript error on staff client place hold screen if record has no items
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-02-28 14:31:35 UTC
Size:
1.77 KB
patch
obsolete
>From da7c80a313bdd7d9c0ef33cd945381177978ab9b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 24 Feb 2014 11:35:52 -0500 >Subject: [PATCH] [SIGNED OFF] Bug 11832 - JavaScript error on staff client > place hold screen if record has no items > >If a hold operation is blocked because the title has no items attached >the patron search autocomplete JavaScript triggers an error. This patch >modifies the template so that the JS is loaded only when items are >present. > >To test, find a title which has no items attached. View the holds page >for that title. There should be no JavaScript error. Patron search >autocomplete should still work correctly for titles which have items >attached. > >Deleted all items from a biblio record. Clicked the holds tab and >confirmed using firebug Javascript error occurs. Applied patch, >confirmed that the Javascript error described in comment 1 no >longer happens. Went to another biblio with items, and confirmed >patron auto-complete still functions. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > .../prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index b084e25..1092166 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -131,7 +131,7 @@ function checkMultiHold() { > > $('#hold-request-form').preventDoubleFormSubmit(); > >-[% UNLESS ( borrowernumber || borrower_list ) %] >+[% UNLESS ( borrowernumber || borrower_list || noitems ) %] > [% IF ( CircAutocompl ) %] > $( "#patron" ).autocomplete({ > source: "/cgi-bin/koha/circ/ysearch.pl", >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11832
:
25590
|
25719
|
26183