Bugzilla – Attachment 2574 Details for
Bug 4832
Re-editing a suggestion changes the item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-4832-Re-editing-a-suggestion-changes-the-ite.patch (text/plain), 2.25 KB, created by
Owen Leonard
on 2010-08-25 20:14:41 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2010-08-25 20:14:41 UTC
Size:
2.25 KB
patch
obsolete
>From 3dd17b57aff664aebd34ad5440f40de861a13fbf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 25 Aug 2010 16:11:46 -0400 >Subject: [PATCH] Fix for 4832 - Re-editing a suggestion changes the item type > >--- > .../prog/en/modules/suggestion/suggestion.tmpl | 2 +- > suggestion/suggestion.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tmpl >index f2227a8..69da865 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tmpl >@@ -110,7 +110,7 @@ h4.collapse a { font-size : 80%; text-decoration: none; } fieldset.brief ol { di > <li><label for="itemtype">Document Type:</label> > <select id="itemtype" name="itemtype" > > <!--TMPL_LOOP Name="itemtypeloop"--> >- <!--TMPL_IF Name="selected"--><option selected="selected" value="<!--TMPL_VAR Name="code" -->"><!--TMPL_ELSE--><option value="<!--TMPL_VAR Name="code" -->"><!--/TMPL_IF--> >+ <!--TMPL_IF Name="selected"--><option selected="selected" value="<!--TMPL_VAR Name="itemtype" -->"><!--TMPL_ELSE--><option value="<!--TMPL_VAR Name="itemtype" -->"><!--/TMPL_IF--> > <!-- TMPL_IF name="imageurl"--><img border="0" src="<!--TMPL_VAR Name="imageurl" -->" alt="<!--TMPL_VAR Name="description" -->" /><!-- /TMPL_IF --> > <!--TMPL_VAR Name="description" --></option> > <!--/TMPL_LOOP--> >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 57a1ba7..8ca17d0 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -249,7 +249,7 @@ $template->param( branchloop => \@branchloop, > # the index parameter is different for item-level itemtypes > my $supportlist=GetSupportList(); > foreach my $support(@$supportlist){ >- $$support{'selected'}= $$support{'code'} eq $$suggestion_ref{'itemtype'}; >+ $$support{'selected'}= $$support{'itemtype'} eq $$suggestion_ref{'itemtype'}; > if ($$support{'imageurl'}){ > $$support{'imageurl'}= getitemtypeimagelocation( 'intranet', $$support{'imageurl'} ); > } >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4832
: 2574