Attachment 25773 Details for Bug 11531 – Bug 11531 - Cannot add new libraries to the transport cost if previously used.

[patch] Bug 11531 - Cannot add new libraries to the transport cost if previously used.

Bug-11531---Cannot-add-new-libraries-to-the-transp.patch (text/plain), 1.66 KB, created by Jonathan Druart on 2014-03-04 11:11:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-03-04 11:11:22 UTC

Size: 1.66 KB

patch

obsolete

>From d127f05405d161ec9f938b6256f73cec06c7b813 Mon Sep 17 00:00:00 2001
>From: ByWater Staff <staff@bywatersolutions.com>
>Date: Mon, 13 Jan 2014 12:39:51 -0500
>Subject: [PATCH] Bug 11531 - Cannot add new libraries to the transport cost
> if previously used.
>
>If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library!
>
>Test Plan:
>1) Enable the transport cost matrix
>2) Set some transport cost values in the matrix
>3) Save the matrix
>4) Create a new library
>5) View the transport cost matrix again
>6) Note the uneditable fields for the new branch
>7) Apply this patch
>8) View the transport cost matrix again
>9) Note you can now edit the fields for the new branch
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> admin/transport-cost-matrix.pl |    4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl
>index 25d3911..faff6ec 100755
>--- a/admin/transport-cost-matrix.pl
>+++ b/admin/transport-cost-matrix.pl
>@@ -91,8 +91,12 @@ foreach my $branchfrom ( @branchloop ) {
>                 if ( my $cell = $cost_matrix->{$tocode}{$fromcode} ) {
>                     $from_to_input_def{value} = $cell->{cost};
>                     $from_to_input_def{disabled} = 1 if $cell->{disable_transfer};
>+                } else {
>+                    # matrix has been previously initialized, but a branch referenced here was created afterward.
>+                    $from_to_input_def{disabled} = 1;
>                 }
>             } else {
>+                # First time initializing the matrix
>                 $from_to_input_def{disabled} = 1;
>             }
>         }
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11531: 24229 | 25773 | 26207