Bugzilla – Attachment 25845 Details for
Bug 11366
Acq basket group "No group" untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11366 - Acq basket group "No group" untranslatable
Bug-11366---Acq-basket-group-No-group-untranslatab.patch (text/plain), 3.35 KB, created by
Fridolin Somers
on 2014-03-05 13:48:41 UTC
(
hide
)
Description:
Bug 11366 - Acq basket group "No group" untranslatable
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-03-05 13:48:41 UTC
Size:
3.35 KB
patch
obsolete
>From 0331d942644b22335f69656489f8afcf84fedaeb Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 5 Mar 2014 14:26:14 +0100 >Subject: [PATCH] Bug 11366 - Acq basket group "No group" untranslatable > >in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. > >This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. > >Test plan : >- Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x >=> You see "No group" selected in combobox "Basket group" >- Cick on this combobox >=> You see "No group", then existing basket groups and then "Add new group" >- Select a basket group and click on "change basket group" >=> You see the basket group name in combobox >Use translation, for example fr-FR >- go to src/misc/translator >- run : perl translate update fr-FR >=> You find in PO file : > #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 > #, fuzzy, c-format > msgid "No group" > msgstr "Nom de groupe" >- remove ", fuzzy" and correct translation : "Pas de groupe" >- run : perl translate install fr-FR >- Go to translated aquisition basket page >=> You see translated option in combobox >--- > acqui/basket.pl | 7 ------- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 3 ++- > 2 files changed, 2 insertions(+), 8 deletions(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index e546948..047ae84 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -306,13 +306,6 @@ if ( $op eq 'delete_confirm' ) { > $basketgroup = $bg; > } > } >- my %emptygroup = ( id => undef, >- name => "No group"); >- if ( ! $basket->{basketgroupid} ) { >- $emptygroup{default} = 1; >- $emptygroup{nogroup} = 1; >- } >- unshift( @$basketgroups, \%emptygroup ); > } > > # if the basket is closed, calculate estimated delivery date >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index e774a6e..cd31176 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -362,7 +362,7 @@ > [%- END -%] > [% ELSE %] > <select id="basketgroupid" name="basketgroupid"> >- <option value="new">Add new group</option> >+ <option value="">No group</option> > [% FOREACH bg IN basketgroups %] > [% IF ( bg.default ) %] > <option value="[% bg.id %]" selected="selected">[% bg.name %]</option> >@@ -374,6 +374,7 @@ > [% END %] > [% END %] > [% END %] >+ <option value="new">Add new group</option> > </select> > <input type="hidden" id="basketno" value="[% basketno %]" name="basketno" /> > <input type="hidden" value="mod_basket" name="op" /> >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11366
:
25845
|
25954
|
26266