Attachment 25877 Details for Bug 5010 – [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog

[patch] [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog

SIGNED-OFF-Bug-5010-Send-list-emails-with-complete.patch (text/plain), 1.60 KB, created by Mark Tompsett on 2014-03-06 00:48:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-03-06 00:48:23 UTC

Size: 1.60 KB

patch

obsolete

>From 9c722f8d2869315419d86695b33acacf2077da6a Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Wed, 11 Dec 2013 12:45:22 +0100
>Subject: [PATCH] [SIGNED OFF] Bug 5010: Send list emails with complete links
> back into the catalog
>
>This patch adapts the way the links in the cart email in OPAC
>are generated for the list emails.
>
>The OpacBaseURL variable is generated from code in Auth.pm.
>
>To test:
>- Create a list
>- Email yourself the list
>  Note: Email is sent directly and not via messagequeue table
>- Verify the links back into the catalog are missing http(s)://
>- Apply the patch
>- Email yourself the list again
>- Verify the links are now ok and working
>
>Note: The way Auth.pm generates the OpacBaseURL is not correct, as
>it does not take into account the OpacBaseURL system preference.
>This patch makes both emails sent from OPAC rely on the same
>code and is an improvement over the current behaviour.
>
>Tested both together using steps similar to larger test plan.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> opac/opac-sendshelf.pl |    4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
>index 80b54e2..d0507fb 100755
>--- a/opac/opac-sendshelf.pl
>+++ b/opac/opac-sendshelf.pl
>@@ -107,10 +107,6 @@ if ( $email ) {
> 
>     my $user = GetMember(borrowernumber => $borrowernumber);
> 
>-    if (C4::Context->preference('OPACBaseURL')){
>-          $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') );
>-    }
>-
>     $template2->param(
>         BIBLIO_RESULTS => \@results,
>         email_sender   => $email_from,
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 5010: 22945 | 23436 | 23457 | 25877 | 25878 | 25879 | 27049 | 27072 | 27431 | 27432 | 27433 | 27435 | 27436 | 27437 | 27673 | 27779 | 27951 | 27952 | 27953 | 27954 | 31727 | 31728 | 31729 | 31787 | 33726 | 35662 | 35760 | 35833 | 35847 | 35852 | 35853 | 35854 | 36177 | 37695 | 38128 | 38658 | 38659 | 38833 | 38834 | 39008 | 39009 | 39086 | 39087 | 39358 | 39359