Attachment 25969 Details for Bug 11912 – Bug 11912: GetMarcISBN wrongly prepends a space to ISBNs

[patch] Bug 11912: GetMarcISBN wrongly prepends a space to ISBNs

Bug-11912-GetMarcISBN-wrongly-prepends-a-space-to-.patch (text/plain), 1.51 KB, created by Tomás Cohen Arazi (tcohen) on 2014-03-09 21:43:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2014-03-09 21:43:16 UTC

Size: 1.51 KB

patch

obsolete

>From 58a3a1f3dc36608b50c018768a45d3ad321e3023 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Sun, 9 Mar 2014 18:39:11 -0300
>Subject: [PATCH] Bug 11912: GetMarcISBN wrongly prepends a space to ISBNs
>
>This patch makes the logic inside GetMarcISBN simpler and
>fixes the issue.
>
>To test:
>- Run the regression tests:
>  prove -v t/db_dependent/Biblio.t
>=> FAIL
>- Apply the patch
>- Run:
>  prove -v t/db_dependent/Biblio.t
>=> SUCCESS
>- Verify that opac-detail.pl and catalogue/detail.pl look as usual regarding ISBN
>- Sign off
>
>Regards
>To+
>
>Sponsored-by: Universidad Nacional de Cordoba
>---
> C4/Biblio.pm | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 330951d..a34e5b6 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -1690,25 +1690,15 @@ sub GetMarcISBN {
>         $scope = '020';
>     }
>     my @marcisbns;
>-    my $isbn = "";
>-    my $tag  = "";
>     my $marcisbn;
>     foreach my $field ( $record->field($scope) ) {
>-        my $value = $field->as_string();
>+        my $isbn = $field->as_string();
>         if ( $isbn ne "" ) {
>             $marcisbn = { marcisbn => $isbn, };
>             push @marcisbns, $marcisbn;
>-            $isbn = $value;
>-        }
>-        if ( $isbn ne $value ) {
>-            $isbn = $isbn . " " . $value;
>         }
>     }
> 
>-    if ($isbn) {
>-        $marcisbn = { marcisbn => $isbn };
>-        push @marcisbns, $marcisbn;    #load last tag into array
>-    }
>     return \@marcisbns;
> }    # end GetMarcISBN
> 
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11912: 25968 | 25969 | 26018 | 26019 | 26277 | 26286 | 26287 | 26288 | 26471 | 26472 | 26473 | 26474 | 26475