Bugzilla – Attachment 25982 Details for
Bug 11794
opacSerialDefaultTab being ignored
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored
PASSED-QA-Bug-11794---opacSerialDefaultTab-being-i.patch (text/plain), 6.57 KB, created by
Katrin Fischer
on 2014-03-10 11:00:22 UTC
(
hide
)
Description:
[PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-03-10 11:00:22 UTC
Size:
6.57 KB
patch
obsolete
>From 43d01549fe27efcf86ec85d666a98f0404ddf758 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 20 Feb 2014 11:38:53 -0500 >Subject: [PATCH] [PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored > >The opacSerialDefaultTab system preference should control whether to >show the holdings or subscriptions tab by default on the detail page for >a serial. This behavior was broken when we last updated jQueryUI because >of a change in the jQueryUI active tab class name. > >This patch corrects the class on the detail page and removes the old >class from the authorities detail page (where it was unnecessary >anyway). > >To test, view a serial record in the OPAC under various settings of the >opacSerialDefaultTab preference. The default tab should correctly follow >the preference. > >Test in prog and Bootstrap themes. > >Edit: Rebased on current master. Note that the change to >opac-auth-detail.tt is because the page never has more than one tab, >hence doesn't need the "active" designation. > >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested in prog and bootstrap. >All tests and QA script pass. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 6 +++--- > 4 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >index 3c5b05f..18a942e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >@@ -108,7 +108,7 @@ > > <div id="authdescriptions" class="toptabs"> > <ul> >- <li id="tab_descriptions" class="ui-tabs-selected"><a href="#descriptions">Notes</a></li> >+ <li id="tab_descriptions"><a href="#descriptions">Notes</a></li> > </ul> > <div id="descriptions"> > <div class="content_set"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 64821b9..d8adb6c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -513,7 +513,7 @@ > > <ul> > [% IF ( defaulttab == 'holdings' ) %] >- <li id="tab_holdings" class="ui-tabs-selected"> >+ <li id="tab_holdings" class="ui-tabs-active"> > [% ELSE %] > <li id="tab_holdings"> > [% END %] >@@ -555,7 +555,7 @@ > [% END %] > > [% IF ( subscriptionsnumber ) %] >- [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-selected">[% ELSE %]<li id="tab_subscriptions">[% END %] >+ [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-active">[% ELSE %]<li id="tab_subscriptions">[% END %] > <a href="#subscriptions">Subscriptions</a> > </li> > [% END %] >@@ -575,7 +575,7 @@ > [% END %] > > [% IF ( serialcollection ) %] >- [% IF ( defaulttab == 'serialcollection' ) %]<li id="tab_serialcollection" class="ui-tabs-selected">[% ELSE %]<li id="tab_serialcollection">[% END %] >+ [% IF ( defaulttab == 'serialcollection' ) %]<li id="tab_serialcollection" class="ui-tabs-active">[% ELSE %]<li id="tab_serialcollection">[% END %] > <a href="#serialcollection">Serial collection</a> > </li> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt >index 78bc5b9..1a46f84 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt >@@ -92,7 +92,7 @@ $(document).ready(function() { > [% END %] > <div id="authdescriptions" class="toptabs"> > <ul> >- <li id="tab_descriptions" class="ui-tabs-selected"><a href="#descriptions">Notes</a></li> >+ <li id="tab_descriptions"><a href="#descriptions">Notes</a></li> > </ul> > <div id="descriptions"> > <div class="content_set"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 26bbbc4..78f60c7 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -937,7 +937,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <div id="bibliodescriptions" class="toptabs"> > > <ul> >- [% IF ( defaulttab == 'holdings' ) %]<li id="tab_holdings" class="ui-tabs-selected">[% ELSE %]<li id="tab_holdings">[% END %] >+ [% IF ( defaulttab == 'holdings' ) %]<li id="tab_holdings" class="ui-tabs-active">[% ELSE %]<li id="tab_holdings">[% END %] > <a href="#holdings">[% IF SeparateHoldings %][% LoginBranchname %] holdings[% ELSE %]Holdings[% END %][% UNLESS too_many_items %] ( [% itemloop.size || 0 %] )[% END %]</a> > </li> > [% IF (SeparateHoldings) %] >@@ -976,7 +976,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > [% END %] > [% END %] > [% IF ( subscriptionsnumber ) %] >- [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-selected">[% ELSE %]<li id="tab_subscriptions">[% END %] >+ [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-active">[% ELSE %]<li id="tab_subscriptions">[% END %] > <a href="#subscriptions">Subscriptions</a> > </li> > [% END %] >@@ -995,7 +995,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > [% END %][% END %] > > [% IF ( serialcollection ) %] >- [% IF ( defaulttab == 'serialcollection' ) %]<li id="tab_serialcollection" class="ui-tabs-selected">[% ELSE %]<li id="tab_serialcollection">[% END %] >+ [% IF ( defaulttab == 'serialcollection' ) %]<li id="tab_serialcollection" class="ui-tabs-active">[% ELSE %]<li id="tab_serialcollection">[% END %] > <a href="#serialcollection">Serial collection</a> > </li> > [% END %] >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11794
:
25515
|
25843
|
25976
|
25977
| 25982