Bugzilla – Attachment 26001 Details for
Bug 11802
Patron purchase suggestions page requires some corrections
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11802 - Patron purchase suggestions page requires some corrections
Bug-11802---Patron-purchase-suggestions-page-requi.patch (text/plain), 3.80 KB, created by
Jonathan Druart
on 2014-03-10 13:17:10 UTC
(
hide
)
Description:
Bug 11802 - Patron purchase suggestions page requires some corrections
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-03-10 13:17:10 UTC
Size:
3.80 KB
patch
obsolete
>From eec599a6aef10edfa38eff6a96fa74d93600df95 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 20 Feb 2014 10:19:42 -0500 >Subject: [PATCH] Bug 11802 - Patron purchase suggestions page requires some > corrections > >This patch corrects some errors with the staff client's patron purchase >suggestions page (members/purchase-suggestions.pl). > >To test, apply the patch and make sure the patronimages system >preference is enabled. > >- View the purchase suggestions page for a patron whose record has a > patron image attached. The image should appear in the left-hand > sidebar. > >- View the page for a patron who has submitted no purchase suggestions. > The message should be styled correctly. > >- The toolbar on the page should look correct and work correctly. > >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > .../prog/en/modules/members/purchase-suggestions.tt | 10 ++++++---- > members/purchase-suggestions.pl | 3 +++ > 2 files changed, 9 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt >index 58e8e24..2d198a2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt >@@ -33,8 +33,8 @@ > <div class="yui-g"> > <h2>Purchase suggestions</h2> > >- <div id="toolbar"> >- <a class="btn" id="newsuggestion" href="/cgi-bin/koha/suggestion/suggestion.pl?op=add&suggestedby=[% borrowernumber %]&redirect=purchase_suggestions&borrowernumber=[% borrowernumber %]"><i class="icon-plus"></i> New purchase suggestion</a> >+ <div id="toolbar" class="btn-toolbar"> >+ <a class="btn btn-small" id="newsuggestion" href="/cgi-bin/koha/suggestion/suggestion.pl?op=add&suggestedby=[% borrowernumber %]&redirect=purchase_suggestions&borrowernumber=[% borrowernumber %]"><i class="icon-plus"></i> New purchase suggestion</a> > </div> > > [% IF suggestions %] >@@ -55,7 +55,7 @@ > <p> > <strong> > [% IF ( CAN_user_catalogue ) %] >- <a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% s.suggestionid %]&op=show">[% s.title |html %]</a> >+ <a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% s.suggestionid %]&op=show">[% s.title |html %]</a> > [% ELSE %] > [% s.title |html %] > [% END %] >@@ -94,7 +94,9 @@ > </tbody> > </table> > [% ELSE %] >- There is no purchase suggestion for this patron. >+ <div class="dialog message"> >+ <p>This patron has not submitted any purchase suggestions</p> >+ </div> > [% END %] > </div> > </div> >diff --git a/members/purchase-suggestions.pl b/members/purchase-suggestions.pl >index d071425..a624b68 100755 >--- a/members/purchase-suggestions.pl >+++ b/members/purchase-suggestions.pl >@@ -51,6 +51,9 @@ $template->param( > branchname => GetBranchName( $borrower->{'branchcode'} ), > ); > >+my ($picture, $dberror) = GetPatronImage($borrowernumber); >+$template->param( picture => 1 ) if $picture; >+ > my $suggestions = SearchSuggestion( { suggestedby => $borrowernumber } ); > > $template->param( suggestions => $suggestions ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11802
:
25511
|
25985
| 26001