Bugzilla – Attachment 26086 Details for
Bug 11801
In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
DBIC version - Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
Bug-11801---In-transit-hold-items-incorrectly-labe.patch (text/plain), 3.74 KB, created by
Biblibre Sandboxes
on 2014-03-11 11:21:38 UTC
(
hide
)
Description:
DBIC version - Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2014-03-11 11:21:38 UTC
Size:
3.74 KB
patch
obsolete
>From 6c2d047ecbf6d56603d1970b39add0a460ecdba7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 20 Feb 2014 10:06:36 -0500 >Subject: [PATCH] Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl > >If an item needs to be transferred to fill a hold, the hold will be >listed as 'Waiting to be pulled" while it is in transit. > >Test Plan: >1) Place a hold for pickup at another library >2) Check in the item, confirm the hold transfer >3) View the holds for that record ( request.pl ) >4) Note the priority is "In transit" and the status is 'Waiting to be > pulled". >5) Apply this patch >6) Reload the holds page >7) Note the status is now "Item being transferred to $branch" > >Signed-off-by: Nadine Michot <nmichot@voila.fr> >--- > .../prog/en/modules/reserve/request.tt | 6 +++--- > reserve/request.pl | 18 +++++++++++++++++- > 2 files changed, 20 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index b084e25..c0aa351 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -657,15 +657,15 @@ function checkMultiHold() { > <td>[% reserveloo.expirationdate %]</td> > <td> > [% IF ( reserveloo.wait ) %] >- [% IF ( reserveloo.atdestination ) %] >+ [% IF ( reserveloo.atdestination ) %] > [% IF ( reserveloo.found ) %] > Item waiting at <b> [% reserveloo.wbrname %]</b> <input type="hidden" name="pickup" value="[% reserveloo.wbrcode %]" /> > [% ELSE %] > Waiting to be pulled <input type="hidden" name="pickup" value="[% reserveloo.wbrcode %]" /> > [% END %] >- [% ELSE %] >+ [% ELSE %] > Item being transferred to <b> [% reserveloo.wbrname %]</b> <input type="hidden" name="pickup" value="[% reserveloo.wbrcode %]" /> >- [% END %] >+ [% END %] > [% ELSE %] > <select name="pickup"> > [% FOREACH branchloo IN reserveloo.branchloop %] >diff --git a/reserve/request.pl b/reserve/request.pl >index 1b303c7..18bf37d 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -43,6 +43,7 @@ use C4::Dates qw/format_date/; > use C4::Members; > use C4::Search; # enabled_staff_search_views > use Koha::DateUtils; >+use Koha::Database; > > my $dbh = C4::Context->dbh; > my $sth; >@@ -475,8 +476,23 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{'wbrcode'} = $res->{'branchcode'}; > $reserve{'itemnumber'} = $res->{'itemnumber'}; > $reserve{'wbrname'} = $branches->{$res->{'branchcode'}}->{'branchname'}; >+ warn $reserve{'holdingbranch'} . "==" . $reserve{'wbrcode'}; > if($reserve{'holdingbranch'} eq $reserve{'wbrcode'}){ >- $reserve{'atdestination'} = 1; >+ # Just because the holdingbranch matches the reserve branch doesn't mean the item >+ # has arrived at the destination, check for an open transfer for the item as well >+ unless ( >+ Koha::Database->new()->schema()->resultset('Branchtransfer') >+ ->count( >+ { >+ itemnumber => $res->{'itemnumber'}, >+ tobranch => $res->{'branchcode'}, >+ datearrived => undef, >+ } >+ ) >+ ) >+ { >+ $reserve{'atdestination'} = 1; >+ } > } > # set found to 1 if reserve is waiting for patron pickup > $reserve{'found'} = 1 if $res->{'found'} eq 'W'; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11801
:
25507
|
25508
|
25509
|
26086
|
26481
|
28664
|
28670