Attachment 26145 Details for Bug 11550 – [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder

[patch] [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder

PASSED-QA-Bug-11550-Add-UT-for-C4AcquisitionGetOrd.patch (text/plain), 1.97 KB, created by Katrin Fischer on 2014-03-12 09:26:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-03-12 09:26:19 UTC

Size: 1.97 KB

patch

obsolete

>From ec66754c377d87d6e886d915fcfacd8ef092aa29 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 14 Jan 2014 12:21:43 +0100
>Subject: [PATCH] [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder
>
>If GetOrder is called with a nonexistent ordernumber or without any
>ordernumber, it should return undef.
>
>Test plan:
>prove t/db_dependent/Acquisition.t
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Updated number of tests to 68, tests and QA script all happy now.
>Looked at a few pages in aquisition using GetOrder as well.
>---
> C4/Acquisition.pm            | 2 ++
> t/db_dependent/Acquisition.t | 7 ++++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 6446a07..33aa8e3 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -1102,6 +1102,8 @@ C<$order> are fields from the biblio, biblioitems, aqorders tables of the Koha d
> 
> sub GetOrder {
>     my ($ordernumber) = @_;
>+    return unless $ordernumber;
>+
>     my $dbh      = C4::Context->dbh;
>     my $query = qq{SELECT
>                 aqorders.*,
>diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t
>index 185b7ac..f2ee820 100755
>--- a/t/db_dependent/Acquisition.t
>+++ b/t/db_dependent/Acquisition.t
>@@ -8,7 +8,7 @@ use POSIX qw(strftime);
> 
> use C4::Bookseller qw( GetBookSellerFromId );
> 
>-use Test::More tests => 66;
>+use Test::More tests => 68;
> 
> BEGIN {
>     use_ok('C4::Acquisition');
>@@ -840,4 +840,9 @@ is( $order3->{'quantityreceived'}, 2,          'Order not split up' );
> is( $order3->{'quantity'},         2,          '2 items on order' );
> is( $order3->{'budget_id'},        $budgetid2, 'Budget has changed' );
> 
>+my $nonexistent_order = GetOrder();
>+is( $nonexistent_order, undef, 'GetOrder returns undef if no ordernumber is given' );
>+$nonexistent_order = GetOrder( 424242424242 );
>+is( $nonexistent_order, undef, 'GetOrder returns undef if a nonexistent ordernumber is given' );
>+
> $dbh->rollback;
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11550: 24277 | 25686 | 25955 | 26124 | 26144 | 26145 | 26146