Bugzilla – Attachment 26147 Details for
Bug 8148
ldap authentication should FAIL if ldap contains NEW password, and user types the PREVIOUS password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth
Bug-8148---LDAP-authbybind-doesnt-fallback-to-loca.patch (text/plain), 1.02 KB, created by
Dobrica Pavlinusic
on 2014-03-12 09:48:24 UTC
(
hide
)
Description:
Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth
Filename:
MIME Type:
Creator:
Dobrica Pavlinusic
Created:
2014-03-12 09:48:24 UTC
Size:
1.02 KB
patch
obsolete
>From 4073c20ab3ead74b6134c317d39904626da368a3 Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Wed, 12 Mar 2014 10:45:09 +0100 >Subject: [PATCH] Bug 8148 - LDAP auth_by_bind doesn't fallback to local auth > >This patch covers LDAP auth_by_bind configuration so that wrong >LDAP password will return -1 to C4::Auth so we can abort local auth >and prevent users logging in with stale database passwords. >--- > C4/Auth_with_ldap.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index fa688cc..e085120 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -145,7 +145,7 @@ sub checkpw_ldap { > my $res = $db->bind( $principal_name, password => $password ); > if ( $res->code ) { > warn "LDAP bind failed as kohauser $userid: " . description($res); >- return 0; >+ return -1; > } > if ( !defined($userldapentry) > && ( $config{update} or $config{replicate} ) ) >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8148
:
25522
|
25523
|
26024
|
26025
|
26147
|
26543
|
29977
|
29978
|
29979
|
30035
|
30036
|
30037
|
30473
|
30524
|
30525
|
30586
|
30587