Attachment 26161 Details for Bug 11833 – [PASSED QA] Bug 11833 - Filtering on saved report subgroup doesn't work

[patch] [PASSED QA] Bug 11833 - Filtering on saved report subgroup doesn't work

PASSED-QA-Bug-11833---Filtering-on-saved-report-su.patch (text/plain), 2.16 KB, created by Katrin Fischer on 2014-03-12 11:33:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-03-12 11:33:54 UTC

Size: 2.16 KB

patch

obsolete

>From fa2c1f2af4b31b20ed8a645abb3d9b6c4c7acf46 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 25 Feb 2014 15:55:03 -0500
>Subject: [PATCH] [PASSED QA] Bug 11833 - Filtering on saved report subgroup
> doesn't work
>
>Filtering the list of saved reports by subgroup doesn't work because the
>filtering JavaScript was not updated when the table columns changed with
>Bug 3134. This patch corrects the target column for filtering.
>
>To test you must have multiple saved reports within one group, and at
>least one of those in a subgroup.
>
>- Apply the patch and go to Reports -> Use saved.
>- Click the tab for the group which contains your reports.
>- Choose the subgroup you want to filter on from the subgroup dropdown.
>
>The list of reports should be correctly filtered by your subgroup.
>
>NOTE: It seems weird to have the number of columns displayed change
>      when filtered, but this patch does correct the filtering.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described, passes all tests and QA script.
>---
> .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index f787cac..6f8bfbe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -114,11 +114,11 @@ $(document).ready(function(){
>         var sg_id = $(selected).val();
>         var sg_name = $(selected).text();
>         if (sg_id.length > 0) {
>-            rtable.fnFilter('^' + sg_name + '$', 4, true, true, true, false);
>-            rtable.fnSetColumnVis(4, false);
>+            rtable.fnFilter('^' + sg_name + '$', 5, true, true, true, false);
>+            rtable.fnSetColumnVis(5, false);
>         } else {
>-            rtable.fnFilter('', 4);
>-            rtable.fnSetColumnVis(4, true);
>+            rtable.fnFilter('', 5);
>+            rtable.fnSetColumnVis(5, true);
>         }
>     });
> 
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11833: 25597 | 25627 | 25630 | 26161