Bugzilla – Attachment 2617 Details for
Bug 4449
Cannot place holds on unchecked-out missing items if AllowShelfHolds turned off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch - signed off
0001-Fix-for-Bug-4449-AllowHoldPolicyOverride-cannot-ove.patch (text/plain), 1.86 KB, created by
Nicole C. Engard
on 2010-09-09 20:48:36 UTC
(
hide
)
Description:
patch - signed off
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2010-09-09 20:48:36 UTC
Size:
1.86 KB
patch
obsolete
>From 6e6d667791fd866940b547cf33ad00fb3cb65d8a Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Thu, 9 Sep 2010 16:19:10 -0400 >Subject: [PATCH] Fix for Bug 4449: AllowHoldPolicyOverride cannot over all policies >Content-Type: text/plain; charset="utf-8" > >AllowHoldPolicyOverride should be able to override AllowOnShelfHolds, as well as other possible reasons for blocking a hold. Before, this only >allowed override of branch policies set in Circ Rules. > >Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> >--- > reserve/request.pl | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 859a65b..963ce26 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -428,14 +428,17 @@ foreach my $biblionumber (@biblionumbers) { > } > > if (IsAvailableForItemLevelRequest($itemnumber) and not $item->{cantreserve} and CanItemBeReserved($borrowerinfo->{borrowernumber}, $itemnumber) ) { >- if ( not $policy_holdallowed and C4::Context->preference( 'AllowHoldPolicyOverride' ) ) { >- $item->{override} = 1; >- $num_override++; >- } elsif ( $policy_holdallowed ) { >+ if ( $policy_holdallowed ) { > $item->{available} = 1; > $num_available++; > } > } >+ # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules >+ if (C4::Context->preference( 'AllowHoldPolicyOverride' ) ) { >+ $item->{override} = 1; >+ $num_override++; >+ } >+ > # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked > > # FIXME: move this to a pm >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4449
: 2617