Attachment 26174 Details for Bug 1047 – Bug 1047 - Punctuation in site names breaks Edit/Delete z39.50 server administration

[patch] Bug 1047 - Punctuation in site names breaks Edit/Delete z39.50 server administration

Bug-1047---Punctuation-in-site-names-breaks-EditDe.patch (text/plain), 3.06 KB, created by Marcel de Rooy on 2014-03-12 13:23:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2014-03-12 13:23:32 UTC

Size: 3.06 KB

patch

obsolete

>From 2a453c47b83f343f2ee2747d0fc12dae4008f3e6 Mon Sep 17 00:00:00 2001
>From: Isaac Brodsky <isaac@isaacbrodsky.com>
>Date: Thu, 27 Feb 2014 09:10:33 -0600
>Subject: [PATCH] Bug 1047 - Punctuation in site names breaks Edit/Delete
> z39.50 server administration
>Content-Type: text/plain; charset=utf-8
>
>The template used to show the Z39.50 server administration page had a bug
>that caused it to not correctly escape generated query strings. Because
>the Z39.50 server name is used to lookup the server in order to edit or delete
>it, when the server name is not passed correctly in the query string, it is
>impossible to bring up the edit or delete forms (without manually entering
>the escaped string.)
>
>This patch corrects which template is filter used to escape those query strings.
>
>To test:
>(1) Login to intranet, go to Administration -> Z39.50 servers
>(2) Select "New Z3.50 Server". Enter a server name that contains an ampersand (&)
>    e.g.: "FOO & BAR". Enter other details and submit. Click OK to confirmation message.
>(3) In the server list, click on the server name, the "Edit" or "Delete" buttons
>    for the server.
>
>The correct and full server details should be brought up.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/modules/admin/z3950servers.tt          |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>index a9c8e4e..1139504 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
>@@ -283,9 +283,9 @@
>                 [% ELSE %]
>                     <tr>
>                 [% END %]
>-<td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">[% loo.name %]</a></td><td>[% loo.host %]:[% loo.port %]</td><td>[% loo.db %]</td><td>[% loo.userid %]</td><td>[% loo.password %]</td><td>[% IF ( loo.checked ) %]Yes[% ELSE %]No[% END %]</td><td>[% loo.rank %]</td>
>+<td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |uri %]">[% loo.name %]</a></td><td>[% loo.host %]:[% loo.port %]</td><td>[% loo.db %]</td><td>[% loo.userid %]</td><td>[% loo.password %]</td><td>[% IF ( loo.checked ) %]Yes[% ELSE %]No[% END %]</td><td>[% loo.rank %]</td>
> 
>-<td>[% loo.syntax %]</td><td>[% loo.encoding %]</td><td>[% loo.timeout %]</td><td>[% loo.recordtype %]</td><td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |url %]">Edit</a></td><td><a href="[% loo.script_name %]?op=delete_confirm&amp;searchfield=[% loo.name |url %]">Delete</a></td>                </tr>
>+<td>[% loo.syntax %]</td><td>[% loo.encoding %]</td><td>[% loo.timeout %]</td><td>[% loo.recordtype %]</td><td><a href="[% loo.script_name %]?op=add_form&amp;searchfield=[% loo.name |uri %]">Edit</a></td><td><a href="[% loo.script_name %]?op=delete_confirm&amp;searchfield=[% loo.name |uri %]">Delete</a></td>                </tr>
>                 [% END %]</tbody>
> </table>
> 
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 1047: 25702 | 25706 | 26174