Attachment 2621 Details for Bug 4904 – new patch with additional changes

[patch] new patch with additional changes

0001-Bug-4904-Problem-with-printing-fines-in-overdue-noti.patch (text/plain), 1.47 KB, created by Katrin Fischer on 2010-09-14 07:49:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2010-09-14 07:49:53 UTC

Size: 1.47 KB

patch

obsolete

>From 025beb504f609299471b089d43e7dac75fe69d5c Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer@bsz-bw.de>
>Date: Sat, 24 Jul 2010 10:37:32 +0200
>Subject: [PATCH] Bug: 4904: Problem with printing fines in overdue notices
>Content-Type: text/plain; charset="utf-8"
>
>my $formatted_fine = currency_format("$1", "$fine", FMT_SYMBOL);
>is already utf-8.
>
>Resend with additional change, removing 2 lines (no strict, use strict) from the code.
>---
> misc/cronjobs/overdue_notices.pl |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 4de6cdd..2e7b2e4 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -662,10 +662,7 @@ sub parse_letter { # FIXME: this code should probably be moved to C4::Letters:pa
>                 $item_format = $1;
>             }
>             if ($params->{'letter'}->{'content'} =~ m/<fine>(.*)<\/fine>/) { # process any fine tags...
>-                no strict; # currency_format behaves badly if we quote the bareword for some reason...
>                 my $formatted_fine = currency_format("$1", "$fine", FMT_SYMBOL);
>-                use strict;
>-                $formatted_fine = Encode::encode("utf8", $formatted_fine);
>                 $params->{'letter'}->{'content'} =~ s/<fine>.*<\/fine>/$formatted_fine/;
>             }
>             $params->{'letter'} = C4::Letters::parseletter( $params->{'letter'}, 'biblio',      $item );
>-- 
>1.6.3.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 4904: 2264 | 2265 | 2266 | 2621