Attachment 26224 Details for Bug 10825 – [SIGNED OFF] Bug 10825 - detail.tt displays duplicated enumchron values for serial items

[patch] [SIGNED OFF] Bug 10825 - detail.tt displays duplicated enumchron values for serial items

SIGNED-OFF-Bug-10825---detailtt-displays-duplicate.patch (text/plain), 2.25 KB, created by Mark Tompsett on 2014-03-13 03:01:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-03-13 03:01:59 UTC

Size: 2.25 KB

patch

obsolete

>From 3565f12f426db5eae3f90d99e570fb7102737680 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Mon, 16 Sep 2013 15:12:16 +1200
>Subject: [PATCH] [SIGNED OFF] Bug 10825 - detail.tt displays duplicated
> enumchron values for serial items
>
>TEST PLAN
>---------
>1) Find a data point that displays like the picture on this
>    bug report.
>2) Apply the patch
>3) Refresh the screen
>4) Does it look like the second picture now with the duplication
>    removed?
>5) Run koha qa test tools
>
>I did attempt with default and blank for the XSLT system
>preferences for the staff client.
>
>This does go against Nicole's comment #12. Counter patch to
>follow.
>
>Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../prog/en/modules/catalogue/detail.tt            |   13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 1e1fcd2..f4cae77 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -658,12 +658,15 @@ function verify_images() {
>                     [% IF ( volinfo ) %]
>                         <td class="enumchron">
>                             [% IF ( itemdata_enumchron ) %]
>-                                [% IF ( item.enumchron ) %]
>-                                    [% item.enumchron %]
>-                                    [% IF ( item.serialseq ) %] -- [% END %]
>+                                [% IF ( item.enumchron  ) %]
>+                                    [% item.enumchron  %]
>+                                [% ELSIF ( item.serialseq ) %]
>+                                    [% item.serialseq %]
>+                                [% END %]
>+
>+                                [% IF ( item.publisheddate ) %]
>+                                    ([% item.publisheddate %])
>                                 [% END %]
>-                                [% item.serialseq %]
>-                                [% IF ( item.publisheddate ) %] ([% item.publisheddate %])[% END %]
>                             [% END %]
>                         </td>
>                     [% END %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10825: 20792 | 20793 | 20794 | 21110 | 21120 | 26224 | 26225 | 27090 | 27100 | 27101 | 27119