Bugzilla – Attachment 26233 Details for
Bug 9016
Multi transport types for notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9016: FIX letter name is not displayed on editing a letter
Bug-9016-FIX-letter-name-is-not-displayed-on-editi.patch (text/plain), 2.69 KB, created by
Olli-Antti Kivilahti
on 2014-03-13 09:50:37 UTC
(
hide
)
Description:
Bug 9016: FIX letter name is not displayed on editing a letter
Filename:
MIME Type:
Creator:
Olli-Antti Kivilahti
Created:
2014-03-13 09:50:37 UTC
Size:
2.69 KB
patch
obsolete
>From f7a5abd7d33369ea0f92ae346c0fc66016d3052a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 13 Mar 2014 09:30:22 +0100 >Subject: [PATCH] Bug 9016: FIX letter name is not displayed on editing a > letter > >On editing a letter, the letter name is not displayed. So if you save >it, the letter name is erased with an empty string. > >Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Tested by setting the "Name"-field in letter.pl, saving, re-editing and verifying >that the email is present in the letter's "Name"-field. >The letter "Name" is replicated for each template in the DB, but that doesn't >incur any performance penalty. >--- > .../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +- > tools/letter.pl | 13 +++++++++---- > 2 files changed, 10 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index 92c3421..d26785a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -286,7 +286,7 @@ $(document).ready(function() { > <span class="label">Code:</span>[% IF ( adding ) %]<input type="text" id="code" name="code" size="20" maxlength="20" />[% ELSE %]<input type="hidden" id="code" name="code" value="[% code %]" />[% code %][% END %] > </li> > <li> >- <label for="name">Name:</label><input type="text" id="name" name="name" size="60" value="[% name %]" /> >+ <label for="name">Name:</label><input type="text" id="name" name="name" size="60" value="[% letter_name %]" /> > </li> > > [% FOREACH letter IN letters %] >diff --git a/tools/letter.pl b/tools/letter.pl >index 2371218..30ce3d2 100755 >--- a/tools/letter.pl >+++ b/tools/letter.pl >@@ -166,14 +166,19 @@ sub add_form { > my $message_transport_types = GetMessageTransportTypes(); > my @letter_loop; > if ($letters) { >+ $template->param( >+ modify => 1, >+ code => $code, >+ branchcode => $branchcode, >+ ); > my $first_flag = 1; >+ # The letter name is contained into each mtt row. >+ # So we can only sent the first one to the template. > for my $mtt ( @$message_transport_types ) { >+ # The letter_name > if ( $first_flag ) { > $template->param( >- modify => 1, >- code => $code, >- branchcode => $branchcode, >- name => $letters->{$mtt}{name}, >+ letter_name=> $letters->{$mtt}{name}, > ); > $first_flag = 0; > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9016
:
13276
|
20814
|
20815
|
20816
|
20916
|
21164
|
21165
|
21166
|
21167
|
21636
|
21637
|
21638
|
21639
|
22814
|
23272
|
23273
|
23289
|
23290
|
23291
|
23292
|
23293
|
23562
|
23955
|
23956
|
23957
|
23958
|
23959
|
23960
|
24571
|
24572
|
24573
|
24574
|
24575
|
24576
|
25006
|
25123
|
25124
|
25125
|
25126
|
25127
|
25128
|
25129
|
25130
|
25415
|
25416
|
25417
|
25418
|
25419
|
25420
|
25421
|
25422
|
25606
|
25899
|
26182
|
26209
|
26210
|
26211
|
26216
|
26226
|
26233
|
26648
|
26649
|
26650
|
26656
|
26657
|
26658
|
26659
|
26660
|
26661
|
26662
|
26663
|
26664
|
26665
|
26666
|
26667
|
26668
|
26670
|
26672
|
26673
|
27794
|
27795
|
27796
|
27797
|
27798
|
27799
|
27800
|
27801
|
27802
|
27803
|
27804
|
27805
|
27806
|
27807
|
27808
|
27809