Bugzilla – Attachment 26301 Details for
Bug 10942
Provide a way for package upgrades to update template translations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10942: (QA followup) Warnings should go to STDERR
Bug-10942-QA-followup-Warnings-should-go-to-STDERR.patch (text/plain), 1.97 KB, created by
Tomás Cohen Arazi (tcohen)
on 2014-03-13 14:39:20 UTC
(
hide
)
Description:
Bug 10942: (QA followup) Warnings should go to STDERR
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-03-13 14:39:20 UTC
Size:
1.97 KB
patch
obsolete
>From f0f1e109b03cb4c8b7c63932b40578379edc4e9a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 13 Mar 2014 11:30:15 -0300 >Subject: [PATCH] Bug 10942: (QA followup) Warnings should go to STDERR > >As noted by Robin, STDOUT is used by the script to communicate with >debconf and, ence, the warning messages should be directed to STDERR. > >This patch does that. To test: > >- Set AUTOMATIC_TRANSLATIONS_UPDATE="no" so the warning normally shows >- Redirect STDOUT to /dev/null: > dpkg -i koha-common...deb > /dev/null >=> Warning message doesn't show (i.e. it is sent to STDOUT) >- Apply the patch, rebuild package >- Redirect STDOUT to /dev/null: > dpkg -i koha-common...deb > /dev/null >=> Warning message shows (i.e. is correctly sent to STDERR) >- Redirect STDERR to /dev/null: > dpkg -i koha-common...deb 2> /dev/null >=> Warning message doesn't show >- Verify that previous tests pass > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > debian/koha-common.postinst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/debian/koha-common.postinst b/debian/koha-common.postinst >index 47acd42..f22bcb0 100644 >--- a/debian/koha-common.postinst >+++ b/debian/koha-common.postinst >@@ -59,7 +59,7 @@ if [ "$AUTOMATIC_TRANSLATIONS_UPDATE" = "yes" ]; then > if koha-translate --update $lang; then > echo "Updated the $lang translations." > else >- cat <<EOF >+ cat <<EOF >&2 > ERROR: an error was found when updating '$lang' translations. Please manually > run 'koha-translate --update $lang'. Run man koha-translate for more options. > EOF >@@ -69,7 +69,7 @@ else > # no auto-update, check update needed and warn if needed > if koha-translate --list | grep -v -q -x "en"; then > # translations installed, update needed >- cat <<EOF >+ cat <<EOF >&2 > Warning: template translations are not set to be automatically updated. > Please manually run 'koha-translate --update lang_code' to update them. > >-- >1.9.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10942
:
21459
|
21461
|
24096
|
24972
|
26122
|
26132
|
26133
|
26134
|
26135
|
26136
|
26137
|
26138
|
26220
|
26221
|
26222
|
26223
|
26301
|
27454
|
27455
|
27456
|
27457
|
27458