Attachment 26338 Details for Bug 10647 – [PASSED QA] Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC

[patch] [PASSED QA] Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC

PASSED-QA-Bug-10647---Make-OPAC-MARC-plain-view-wo.patch (text/plain), 2.76 KB, created by Katrin Fischer on 2014-03-14 11:08:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-03-14 11:08:35 UTC

Size: 2.76 KB

patch

obsolete

>From bfc6e82ff1106d3c375d4ea1b460898605e8b92a Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@enger.priv.no>
>Date: Fri, 7 Mar 2014 09:10:49 +0100
>Subject: [PATCH] [PASSED QA] Bug 10647 - Make OPAC MARC plain view work for
> all flavours of MARC
>
>On "MARC view" in the OPAC, clicking on "Plain view" does not work
>for UNIMARC and NORMARC.
>
>To test:
>- Make sure you have a UNIMARC or NORMARC setup
>- Go to the "MARC view" of a record in the OPAC
>- Click on "view plain" and observe the "Sorry, plain view is
>  temporarily unavailable." error message
>- Apply the patch
>- Click on "view plain" and observe that a plain view of the MARC
>  record is now displayed
>- Sign off
>
>I have only tested this on NORMARC, it might be good if someone
>can test on UNIMARC.
>
>Updated 2014-03-13: Incoroprates changes suggested by Marcel.
>Test plan is the same as before.
>
>Updated 2014-03-13: Tested in my UNIMARC system.
>toggled opactheme to all three values, with OPACXSLTDetailsDisplay
>and OPACXSLTResultsDisplay both set to default.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Tested with MARC21 and UNIMARC, passes all tests and QA script.
>---
> .../bootstrap/en/xslt/{MARC21slim2OPACMARCdetail.xsl => plainMARC.xsl}  | 0
> .../prog/en/xslt/{MARC21slim2OPACMARCdetail.xsl => plainMARC.xsl}       | 0
> opac/opac-showmarc.pl                                                   | 2 +-
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename koha-tmpl/opac-tmpl/bootstrap/en/xslt/{MARC21slim2OPACMARCdetail.xsl => plainMARC.xsl} (100%)
> rename koha-tmpl/opac-tmpl/prog/en/xslt/{MARC21slim2OPACMARCdetail.xsl => plainMARC.xsl} (100%)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACMARCdetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/plainMARC.xsl
>similarity index 100%
>rename from koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACMARCdetail.xsl
>rename to koha-tmpl/opac-tmpl/bootstrap/en/xslt/plainMARC.xsl
>diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACMARCdetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/plainMARC.xsl
>similarity index 100%
>rename from koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACMARCdetail.xsl
>rename to koha-tmpl/opac-tmpl/prog/en/xslt/plainMARC.xsl
>diff --git a/opac/opac-showmarc.pl b/opac/opac-showmarc.pl
>index 27ab61c..c78b5b1 100755
>--- a/opac/opac-showmarc.pl
>+++ b/opac/opac-showmarc.pl
>@@ -71,7 +71,7 @@ if ($view eq 'card' || $view eq 'html') {
>         $xslfile = "compact.xsl";
>     }
>     else { # must be html
>-        $xslfile = C4::Context->preference('marcflavour') . "slim2OPACMARCdetail.xsl";
>+        $xslfile = 'plainMARC.xsl';
>     }
>     $xslfilename = "$htdocs/$theme/$lang/xslt/$xslfile";
>     $xslfilename = "$htdocs/$theme/en/xslt/$xslfile" unless ( $lang ne 'en' && -f $xslfilename );
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 10647: 25929 | 25931 | 26310 | 26323 | 26338