Attachment 2639 Details for Bug 4218 – Proposed fix

[patch] Proposed fix

0001-Fix-for-Bug-4218-Staff-client-detail-page-does-not-s.patch (text/plain), 3.09 KB, created by Owen Leonard on 2010-09-21 16:54:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2010-09-21 16:54:59 UTC

Size: 3.09 KB

patch

obsolete

>From 7ea993d7da350d7dca588af13236c979b6d6ed6f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 Sep 2010 12:47:43 -0400
>Subject: [PATCH] Fix for Bug 4218 - Staff client detail page does not show item hold status
>
>Showing "on hold" in the holdings list (as we used to do) is misleading
>if it is a bibilo-level hold. However seeing that a title has holds
>is important information for this view. This patch adds a line to the
>biblio-level information display with a count of the title's outstanding
>holds.
>---
> catalogue/detail.pl                                |    4 ++++
> .../intranet-tmpl/prog/en/css/staff-global.css     |    3 +++
> .../prog/en/modules/catalogue/detail.tmpl          |    3 +--
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 85819c0..176efce 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -102,6 +102,9 @@ my $dbh = C4::Context->dbh;
> my @items = &GetItemsInfo( $biblionumber, 'intra' );
> my $dat = &GetBiblioData($biblionumber);
> 
>+# get count of holds
>+my ( $holdcount, $holds ) = GetReservesFromBiblionumber($biblionumber,1);
>+
> #coping with subscriptions
> my $subscriptionsnumber = CountSubscriptionFromBiblionumber($biblionumber);
> my @subscriptions       = GetSubscriptions( $dat->{title}, $dat->{issn}, $biblionumber );
>@@ -214,6 +217,7 @@ $template->param(
> 	itemdata_copynumber => $itemfields{copynumber},
> 	volinfo				=> $itemfields{enumchron} || $dat->{'serial'} ,
> 	z3950_search_params	=> C4::Search::z3950_search_args($dat),
>+    holdcount           => $holdcount,
> 	C4::Search::enabled_staff_search_views,
> );
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index 13ac2c7..1ab3fad 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -1883,3 +1883,6 @@ ul.budget_hierarchy li:last-child:after {
> ul.budget_hierarchy li:first-child:after {
>     content: "";
> }
>+.holdcount { font-size : 105%; line-height : 200%; }
>+.holdcount a { border : 1px solid #a4bedd; background-color : #e4ecf5; font-weight : bold; -moz-border-radius: 4px; padding : .1em .4em; text-decoration : none; }
>+.holdcount a:hover { background-color : #ebeff7; }
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl
>index 1861028..a153ebf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl
>@@ -185,11 +185,10 @@ function verify_images() {
> 	        </ul>
> 	        </li>
>         
>+            <li><strong>Holds:</strong> <span class="holdcount"><a href="/cgi-bin/koha/reserve/request.pl?biblionumber="></a></span></li>
>         </ul>
>-        
> </div>
> </div>
>-
> <div id="bibliodetails" class="toptabs">
> 
> <ul>   
>-- 
>1.7.0.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 4218: 2638 | 2639 | 3325