Bugzilla – Attachment 26458 Details for
Bug 9032
Share a list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9032: QA Follow-up: Use loop variable instead of $_ in opac-shareshelf
Bug-9032-QA-Follow-up-Use-loop-variable-instead-of.patch (text/plain), 859 bytes, created by
Marcel de Rooy
on 2014-03-19 15:58:03 UTC
(
hide
)
Description:
Bug 9032: QA Follow-up: Use loop variable instead of $_ in opac-shareshelf
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-03-19 15:58:03 UTC
Size:
859 bytes
patch
obsolete
>From 1c96a4bca915ba90a0738f338cc9f8616e2ba187 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 19 Mar 2014 16:56:23 +0100 >Subject: [PATCH] Bug 9032: QA Follow-up: Use loop variable instead of $_ in > opac-shareshelf >Content-Type: text/plain; charset=utf-8 > >--- > opac/opac-shareshelf.pl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-shareshelf.pl b/opac/opac-shareshelf.pl >index 9e12266..97fe8b2 100755 >--- a/opac/opac-shareshelf.pl >+++ b/opac/opac-shareshelf.pl >@@ -283,8 +283,8 @@ sub stringtokey { > > sub alphabet_ordinal { > my ($char, $alphabet) = @_; >- for( 0..$#$alphabet ) { >- return $_ if $char eq $alphabet->[$_]; >+ for my $ord ( 0..$#$alphabet ) { >+ return $ord if $char eq $alphabet->[$ord]; > } > return ''; #ignore missing chars > } >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9032
:
18260
|
18542
|
18543
|
18546
|
18547
|
18587
|
18619
|
18682
|
18692
|
19377
|
19378
|
19379
|
19394
|
19934
|
19935
|
25847
|
25848
|
25849
|
25850
|
25851
|
25852
|
25853
|
25862
|
25886
|
25893
|
26253
|
26291
|
26292
|
26293
|
26294
|
26295
|
26296
|
26297
|
26298
|
26299
|
26300
|
26302
|
26303
|
26351
|
26458
|
26509
|
26513
|
26577
|
26578
|
26579
|
26580
|
26581
|
26582
|
26583
|
26584
|
26585
|
26586
|
26587
|
26588