Attachment 26536 Details for Bug 10613 – Bug 10613: FIX QA issues

[patch] Bug 10613: FIX QA issues

Bug-10613-FIX-QA-issues.patch (text/plain), 974 bytes, created by Jonathan Druart on 2014-03-24 16:00:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-03-24 16:00:50 UTC

Size: 974 bytes

patch

obsolete

>From 0c01deccab72711aaa4f4ddd18b3a89d64dd189f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Mon, 24 Mar 2014 10:11:47 +0100
>Subject: [PATCH] Bug 10613: FIX QA issues
>
>This patch fixes the following QA issue:
>
> FAIL    acqui/invoice.pl
>   FAIL      valid
>        Useless use of private variable in void context
>---
> acqui/invoice.pl |    5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/acqui/invoice.pl b/acqui/invoice.pl
>index c59c490..95065c9 100755
>--- a/acqui/invoice.pl
>+++ b/acqui/invoice.pl
>@@ -123,9 +123,8 @@ foreach my $order (@$orders) {
>     $foot{$$line{gstgsti}}{totalgsti} += $$line{totalgsti};
>     $total_gsti += $$line{totalgsti};
> 
>-    my %row = %{ $order, $line };
>-    $row{'orderline'} = $row{'parent_ordernumber'};
>-    push @orders_loop, \%row;
>+    $line->{orderline} = $line->{parent_ordernumber};
>+    push @orders_loop, $line;
> }
> 
> push @foot_loop, map {$_} values %foot;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10613: 19788 | 22389 | 25889 | 25890 | 26529 | 26534 | 26535 | 26536 | 26558 | 26924 | 26925 | 26926