Attachment 26562 Details for Bug 11563 – Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns

[patch] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns

Bug-11563-QA-Followup---Disable-add-noEnterSubmit-.patch (text/plain), 2.18 KB, created by Biblibre Sandboxes on 2014-03-25 15:33:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2014-03-25 15:33:08 UTC

Size: 2.18 KB

patch

obsolete

>From 291bc78baf88cd891989b60352325065e6357a59 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 7 Mar 2014 09:05:31 -0500
>Subject: [PATCH] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns
>
>When using Chrome on Mac OS X, form submits are triggered by hitting
>enter when focused on a select. This is not an issue with any other
>combincation of browser and operating system that I am aware of.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>---
> .../prog/en/modules/cataloguing/additem.tt         |    2 +-
> .../prog/en/modules/members/memberentrygen.tt      |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 2e3ddc3..23ae204 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -20,7 +20,7 @@ $(document).ready(function(){
>             window.close();
>         [% END %]
>     [% END %]
>-            $("fieldset.rows input").addClass("noEnterSubmit");
>+            $("fieldset.rows input,select").addClass("noEnterSubmit");
> 		/* Inline edit/delete links */
> 		var biblionumber = $("input[name='biblionumber']").attr("value");
>         $("tr.editable td").click(function(event){
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 720193f..5e9225f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -8,7 +8,7 @@
> <script type="text/javascript">
> //<![CDATA[
>     $(document).ready(function() {
>-         $("fieldset.rows input").addClass("noEnterSubmit");
>+         $("fieldset.rows input,select").addClass("noEnterSubmit");
>         $("#guarantordelete").click(function() {
>             $("#contact-details").hide().find('a').remove();
>             $("#guarantorid, #contactname, #contactfirstname").each(function () { this.value = "" });
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11563: 25615 | 25676 | 25678 | 25935 | 26443 | 26444 | 26445 | 26545 | 26560 | 26561 | 26562 | 26563 | 26566 | 26567 | 26568 | 26569 | 26570 | 26571 | 26572 | 26573