Bugzilla – Attachment 26642 Details for
Bug 7567
News by Library: refactor, enhance, and fix
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7567: QA followup: FIX SQL query
Bug-7567-QA-followup-FIX-SQL-query.patch (text/plain), 896 bytes, created by
Jonathan Druart
on 2014-03-27 12:26:14 UTC
(
hide
)
Description:
Bug 7567: QA followup: FIX SQL query
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-03-27 12:26:14 UTC
Size:
896 bytes
patch
obsolete
>From 3f2f015dea30c93ba673c3777d2d97166520f91e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 27 Mar 2014 13:14:08 +0100 >Subject: [PATCH] Bug 7567: QA followup: FIX SQL query > >The WHERE clause should not erase $query. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/NewsChannels.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/NewsChannels.pm b/C4/NewsChannels.pm >index 7c413aa..acefb70 100644 >--- a/C4/NewsChannels.pm >+++ b/C4/NewsChannels.pm >@@ -150,7 +150,7 @@ sub get_opac_news { > FROM opac_news LEFT JOIN branches > ON opac_news.branchcode=branches.branchcode > }; >- $query = ' WHERE 1'; >+ $query .= ' WHERE 1'; > if ($lang) { > $query .= " AND (opac_news.lang='' OR opac_news.lang=?)"; > push @values,$lang; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7567
:
22863
|
22917
|
22920
|
23350
|
23351
|
23352
|
23362
|
23368
|
23378
|
23383
|
23386
|
23474
|
23475
|
23501
|
23544
|
23547
|
23552
|
23553
|
23554
|
23559
|
23664
|
23703
|
23704
|
23705
|
25316
|
25317
|
25318
|
25319
|
25320
|
25321
|
25322
|
25323
|
25324
|
25325
|
25331
|
25332
|
25333
|
26510
|
26511
|
26590
|
26591
|
26592
|
26593
|
26594
|
26595
|
26596
|
26597
|
26598
|
26599
|
26600
|
26601
|
26602
|
26603
|
26604
|
26605
|
26606
|
26607
|
26608
|
26609
|
26610
|
26611
|
26612
|
26631
|
26632
|
26633
|
26634
|
26635
|
26636
|
26637
|
26638
|
26639
|
26640
|
26641
| 26642 |
26643
|
26644
|
26647