Attachment 26643 Details for Bug 7567 – Bug 7567: QA followup: remove useless $parameters hashref

[patch] Bug 7567: QA followup: remove useless $parameters hashref

Bug-7567-QA-followup-remove-useless-parameters-has.patch (text/plain), 2.47 KB, created by Jonathan Druart on 2014-03-27 12:26:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-03-27 12:26:23 UTC

Size: 2.47 KB

patch

obsolete

>From 923cffc846326e0f157a1e2e559fd3f0129e9d53 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 27 Mar 2014 13:15:14 +0100
>Subject: [PATCH] Bug 7567: QA followup: remove useless $parameters hashref
>
>This hashref is useless, it is only used once.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> tools/koha-news.pl |   44 +++++++++++++++++++++++---------------------
> 1 file changed, 23 insertions(+), 21 deletions(-)
>
>diff --git a/tools/koha-news.pl b/tools/koha-news.pl
>index 734db7c..aec9486 100755
>--- a/tools/koha-news.pl
>+++ b/tools/koha-news.pl
>@@ -96,30 +96,32 @@ if ( $op eq 'add_form' ) {
>     }
> }
> elsif ( $op eq 'add' ) {
>-    my $parameters = {
>-                      title          => $title,
>-                      new            => $new,
>-                      lang           => $lang,
>-                      expirationdate => $expirationdate,
>-                      timestamp      => $timestamp,
>-                      number         => $number,
>-                      branchcode     => $branchcode,
>-                  };
>-    add_opac_new( $parameters );
>+    add_opac_new(
>+        {
>+            title          => $title,
>+            new            => $new,
>+            lang           => $lang,
>+            expirationdate => $expirationdate,
>+            timestamp      => $timestamp,
>+            number         => $number,
>+            branchcode     => $branchcode,
>+        }
>+    );
>     print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
> }
> elsif ( $op eq 'edit' ) {
>-    my $parameters = {
>-                      idnew          => $id,
>-                      title          => $title,
>-                      new            => $new,
>-                      lang           => $lang,
>-                      expirationdate => $expirationdate,
>-                      timestamp      => $timestamp,
>-                      number         => $number,
>-                      branchcode     => $branchcode,
>-                  };
>-    upd_opac_new( $parameters );
>+    upd_opac_new(
>+        {
>+            idnew          => $id,
>+            title          => $title,
>+            new            => $new,
>+            lang           => $lang,
>+            expirationdate => $expirationdate,
>+            timestamp      => $timestamp,
>+            number         => $number,
>+            branchcode     => $branchcode,
>+        }
>+    );
>     print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
> }
> elsif ( $op eq 'del' ) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 7567: 22863 | 22917 | 22920 | 23350 | 23351 | 23352 | 23362 | 23368 | 23378 | 23383 | 23386 | 23474 | 23475 | 23501 | 23544 | 23547 | 23552 | 23553 | 23554 | 23559 | 23664 | 23703 | 23704 | 23705 | 25316 | 25317 | 25318 | 25319 | 25320 | 25321 | 25322 | 25323 | 25324 | 25325 | 25331 | 25332 | 25333 | 26510 | 26511 | 26590 | 26591 | 26592 | 26593 | 26594 | 26595 | 26596 | 26597 | 26598 | 26599 | 26600 | 26601 | 26602 | 26603 | 26604 | 26605 | 26606 | 26607 | 26608 | 26609 | 26610 | 26611 | 26612 | 26631 | 26632 | 26633 | 26634 | 26635 | 26636 | 26637 | 26638 | 26639 | 26640 | 26641 | 26642 | 26643 | 26644 | 26647