Attachment 26644 Details for Bug 7567 – Bug 7567 - Modify DataTables configuration

[patch] Bug 7567 - Modify DataTables configuration

Bug-7567---Modify-DataTables-configuration.patch (text/plain), 2.92 KB, created by Owen Leonard on 2014-03-27 13:35:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-03-27 13:35:31 UTC

Size: 2.92 KB

patch

obsolete

>From 3d953a0fba36660a0062bb20fe232888536bb3f5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 27 Mar 2014 09:30:24 -0400
>Subject: [PATCH] Bug 7567 - Modify DataTables configuration
>Content-Type: text/plain; charset="utf-8"
>
>This follow-up corrects a JavaScript error by converting the sorting
>configuration to be class-based
>(http://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference).
>
>I have also changed the DataTables configuration to allow for pagination
>and JS-based filtering.
>
>To test, apply the patch and view the list of News items. Your browser
>should report no JavaScript errors. Table sorting, pagination, and
>filtering should work correctly.
>---
> .../prog/en/modules/tools/koha-news.tt             |   15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>index 39cde86..842bed9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>@@ -9,14 +9,11 @@
>     <script type="text/javascript">//<![CDATA[
>     $(document).ready(function() {
>         $("#newst").dataTable($.extend(true, {}, dataTablesDefaults, {
>-            "sDom": 't',
>             "aoColumnDefs": [
>-                { "aTargets": [ 0,-1,-2 ], "bSortable": false, "bSearchable": false }
>+                { "aTargets": [ 0,-1,-2 ], "bSortable": false },
>+                { "aTargets": [ 0, -1 ], "bSearchable": false },
>+                { 'sType': "title-string", 'aTargets' : [ 'title-string'] }
>             ],
>-            "aoColumns": [
>-                null,null,null,{ "sType": "title-string" },{ "sType": "title-string" },null,null,null
>-            ],
>-            "bPaginate": false
>         }));
>     });
>     //]]>
>@@ -62,7 +59,7 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div>
> 
> [% UNLESS ( add_form ) %]
> <div id="toolbar" class="btn-toolbar">
>-    <a class="btn btn-small" id="newentry" href="/cgi-bin/koha/tools/koha-news.pl?op=add_form&lang=[% lang %]"><i class="icon-plus"></i> New entry</a>
>+    <a class="btn btn-small" id="newentry" href="/cgi-bin/koha/tools/koha-news.pl?op=add_form&amp;lang=[% lang %]"><i class="icon-plus"></i> New entry</a>
> </div>
> [% END %]
> 
>@@ -206,8 +203,8 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div>
>                         <th>Location</th>
>                         <th>Library</th>
>                         <th>Number</th>
>-                        <th>Creation date</th>
>-                        <th>Expiration date</th>
>+                        <th class="title-string">Creation date</th>
>+                        <th class="title-string">Expiration date</th>
>                         <th>Title</th>
>                         <th>News</th>
>                         <th>&nbsp;</th>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 7567: 22863 | 22917 | 22920 | 23350 | 23351 | 23352 | 23362 | 23368 | 23378 | 23383 | 23386 | 23474 | 23475 | 23501 | 23544 | 23547 | 23552 | 23553 | 23554 | 23559 | 23664 | 23703 | 23704 | 23705 | 25316 | 25317 | 25318 | 25319 | 25320 | 25321 | 25322 | 25323 | 25324 | 25325 | 25331 | 25332 | 25333 | 26510 | 26511 | 26590 | 26591 | 26592 | 26593 | 26594 | 26595 | 26596 | 26597 | 26598 | 26599 | 26600 | 26601 | 26602 | 26603 | 26604 | 26605 | 26606 | 26607 | 26608 | 26609 | 26610 | 26611 | 26612 | 26631 | 26632 | 26633 | 26634 | 26635 | 26636 | 26637 | 26638 | 26639 | 26640 | 26641 | 26642 | 26643 | 26644 | 26647