Bugzilla – Attachment 2665 Details for
Bug 2664
Additem form should preselect logged-in branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-2664-Add-item-should-preselect-logged-in-branch.patch (text/plain), 1.28 KB, created by
Colin Campbell
on 2010-10-05 09:43:59 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2010-10-05 09:43:59 UTC
Size:
1.28 KB
patch
obsolete
>From 91aac32f52ad6d83b0e111980541ed28647d6a9b Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 5 Oct 2010 10:28:59 +0100 >Subject: [PATCH] Bug 2664: Add item should preselect logged in branch >Content-Type: text/plain; charset="utf-8" > >An earlier fix to stop branch values being overwritten in >edit items was causing the branch value to be unset when adding items >--- > cataloguing/additem.pl | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index ea4daf9..e6f19d2 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -433,7 +433,10 @@ foreach my $tag (sort keys %{$tagslib}) { > foreach my $thisbranch (@$branches) { > push @authorised_values, $thisbranch->{value}; > $authorised_lib{$thisbranch->{value}} = $thisbranch->{branchname}; >- # $value = $thisbranch->{value} if $thisbranch->{selected}; >+ # in edit item this is set to the data value otherwise use default >+ if ($op ne 'edititem' && $thisbranch->{selected} ) { >+ $value = $thisbranch->{value}; >+ } > } > } > elsif ( $tagslib->{$tag}->{$subfield}->{authorised_value} eq "itemtypes" ) { >-- >1.7.2.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2664
:
781
| 2665