Bugzilla – Attachment 26799 Details for
Bug 12034
MSG_REMOVE_FROM_LIST different wording between OPAC and staff client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client
SIGNED-OFF-Bug-12034---MSGREMOVEFROMLIST-different.patch (text/plain), 3.52 KB, created by
Bernardo Gonzalez Kriegel
on 2014-04-03 17:33:44 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-04-03 17:33:44 UTC
Size:
3.52 KB
patch
obsolete
>From 3148c3cc579355e060973369d1ebec055de361c8 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 3 Apr 2014 08:38:08 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different > wording between OPAC and staff client > >The staff client lists template contains a warning which differs from >the same warning in the OPAC. The OPAC version is correct because it >refers to a list rather than a shelf. This patch copies the OPAC version >to the staff client template. > >This patch also corrects a few of other instances where the incorrect >term "shelf" is used. > >To test, apply the patch and view a list in the staff client which is >populated with items. Check the box next to one or more items on the >list and click the "Remove selected" button. You should see the message, >"Are you sure you want to remove these items from the list?" > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Work as described, no koha-qa errors >--- > .../prog/en/modules/virtualshelves/shelves.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index aca9485..05f28f1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -9,7 +9,7 @@ > //<![CDATA[ > > var MSG_NO_ITEM_SELECTED = _("Nothing is selected."); >-var MSG_REMOVE_FROM_LIST = _("Are you sure you want to remove these records from the shelf?"); >+var MSG_REMOVE_FROM_LIST = _("Are you sure you want to remove these items from the list?"); > var MSG_CONFIRM_DELETE_LIST = _("Are you sure you want to remove this list?"); > [% IF ( viewshelf ) %] > $(document).ready(function(){ >@@ -230,7 +230,7 @@ function placeHold () { > [% IF ( paramsloo.already ) %]<div class="dialog alert">A List named [% paramsloo.already %] already exists!</div>[% END %] > [% IF ( paramsloo.status ) %]<div class="dialog alert">[% paramsloo.string %]</div>[% END %] > [% IF ( paramsloo.nobarcode ) %]<div class="dialog alert">ERROR: No barcode given.</div>[% END %] >- [% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No shelfnumber given.</div>[% END %] >+ [% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No list number given.</div>[% END %] > [% IF ( paramsloo.need_confirm ) %] > <div class="dialog alert">The list <i>[% paramsloo.need_confirm %]</i> is not empty. > <br />It has <b>[% paramsloo.count %]</b> entries. >@@ -247,10 +247,10 @@ function placeHold () { > <div class="dialog alert">A record matching barcode <b>[% paramsloo.duplicatebiblio %]</b> has already been added.</div> > [% END %] > [% IF ( paramsloo.nothingdeleted) %] >- <div class="dialog message">Warning: You could not delete any selected items from this shelf.</div> >+ <div class="dialog message">Warning: You could not delete any of the selected items from this list.</div> > [% END %] > [% IF ( paramsloo.somedeleted) %] >- <div class="dialog message">Warning: You could not delete all selected items from this shelf.</div> >+ <div class="dialog message">Warning: You could not delete all selected items from this list.</div> > [% END %] > [% IF ( paramsloo.modifyfailure) %] > <div class="dialog message">ERROR: List could not be modified.</div> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12034
:
26789
|
26799
|
26812